bpo-39673: Map errno==ETIME to TimeoutError #20253
Open
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvsmith
reviewed
May 24, 2020
ericvsmith
reviewed
May 25, 2020
Misc/NEWS.d/next/Library/2020-05-19-23-16-53.bpo-39673.ppfScY.rst
Outdated
Show resolved
Hide resolved
Updated blurb to reflect that it's an OSError that's being mapped to a TimeoutError.
ericvsmith
reviewed
May 26, 2020
| @@ -65,7 +65,7 @@ def test_select_error(self): | |||
| +-- NotADirectoryError ENOTDIR | |||
| +-- PermissionError EACCES, EPERM | |||
| +-- ProcessLookupError ESRCH | |||
| +-- TimeoutError ETIMEDOUT | |||
| +-- TimeoutError ETIME, ETIMEDOUT | |||
There was a problem hiding this comment.
I guess this test is as good as we're going to get.
There was a problem hiding this comment.
To be honest, I'm having second thoughts w.r.t. this PR (especially after the discussion
on python-dev). I don't know a lot about ETIME. I'm not sure if I should have submitted this PR.
There was a problem hiding this comment.
@ZackerySpytz No need to worry, its only being added to future version of python. With more and more async style coding being adapted ETIME will be handy to have as TimeoutError. It should have been adapted a long time ago but i suppose no one wanted to bother submitting a PR for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue39673