New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Improve arg-param mapping logic to better handle arguments passed to params
parameters
#15175
Conversation
I checked some of the new issues in the DCA results. There is at least one false positive in Method(new object(), null);
void Method(params object[] objs)
{
var x = objs.Length; // reports objs can be null, because of the null arg in the call.
} At the same time, there are new true positives found in |
The second DCA run seems good. We find 3 additional alerts, all end in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks plausible to me, but I would also like a second set of eyes on the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…params` parameters
…d to `params` parameters
7efc79c
to
e67035f
Compare
This PR changes
Call::getArgumentForParameter
to better cover cases when arguments are passed toparams
parameters.Commit-by-commit review is suggested.