Skip to content

/ arduino-builder

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No sketch folder property in build properties #24

Closed
stevemarple opened this issue Sep 30, 2015 · 4 comments
Closed

No sketch folder property in build properties #24

stevemarple opened this issue Sep 30, 2015 · 4 comments
Assignees
@ffissore
Labels
bug

Comments

@stevemarple
Copy link

@stevemarple stevemarple commented Sep 30, 2015

build.source.path contains the absolute name of the sketch .ino file. No property exists which defines the sketch folder. This is required for recipes which need to reference files within the original sketch folder.

The closest available is build.path (/tmp/...) but when referencing files in there the timestamp changes which forces compilation to be run even when not required.
@stevemarple stevemarple mentioned this issue Sep 30, 2015
Closed
@ffissore
Copy link
Contributor

@ffissore ffissore commented Oct 1, 2015

Are you sure? build.source.path is part of build properties since first release. See https://github.com/arduino/arduino-builder/blob/master/src/arduino.cc/builder/setup_build_properties.go#L98-L104
This is visible even when running -dump-prefs (the first command the IDE runs when you compile)
Can you add some more details and possibly share your platform.txt?
@ffissore ffissore added the question label Oct 1, 2015
@ffissore ffissore self-assigned this Oct 1, 2015
@stevemarple
Copy link
Author

@stevemarple stevemarple commented Oct 1, 2015

build.source.path was what I expected to use, dumping prefs I get the .ino file, not its folder.

build.source.path=/home/mango/marple/work/arduino15/sketches/sketch_sep24a/sketch_sep24a.ino

I'm using the standard AVR platform.txt file from an unmodifed version of arduino/Arduino (commit 435fc323e0ab3b03bc5835e5309b5022bf57388a)
@ffissore
Copy link
Contributor

@ffissore ffissore commented Oct 1, 2015

Ahh you're right. I mistakenly set it to the sketch file instead of its folder. Fixing it right now
@ffissore ffissore added bug and removed question labels Oct 1, 2015
@ffissore ffissore closed this in 0296899 Oct 1, 2015
@ffissore
Copy link
Contributor

@ffissore ffissore commented Oct 1, 2015

Ok, fix will be available with next IDE hourly, which is being built http://www.arduino.cc/en/Main/Software#hourly
stevemarple added a commit to stevemarple/arduino-builder that referenced this issue Oct 1, 2015
Federico Fissore @stevemarple
BUILD_PROPERTIES_SOURCE_PATH was set to main .ino file location, whil…
71f754f 
…e it must

be set to its container folder. Fixes arduino#24

Signed-off-by: Federico Fissore <f.fissore@arduino.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffissore ffissore

Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ffissore @stevemarple
You can’t perform that action at this time.