gh-105375: Improve error handling in _Unpickler_SetInputStream() #105667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent exceptions from possibly being overwritten in case of multiple failures.
erlend-aasland
added
needs backport to 3.11
18 tasks
|
@serhiy-storchaka, would you have time to look at this bugfix? |
- There's no need to match AttributeError, since _PyObject_LookupAttr() converts that exception into a return value of 0. - We can use the result output variable instead of adding temporary boolean indicators.
Don't clear arbitrary exceptions
There's no need for PyErr_Occurred() anymore
|
Thanks for the very helpful review and historical insight, Serhiy. |
serhiy-storchaka
approved these changes
Jun 13, 2023
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-105720 is a backport of this pull request to the 3.12 branch. |
|
GH-105721 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Jun 13, 2023
…Stream() (python#105667) Prevent exceptions from possibly being overwritten in case of multiple failures. (cherry picked from commit 217589d) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
added a commit
to erlend-aasland/cpython
that referenced
this pull request
Jun 13, 2023
…Stream() (python#105667) Prevent exceptions from possibly being overwritten in case of multiple failures. (cherry picked from commit 217589d) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland
added a commit
that referenced
this pull request
Jun 13, 2023
erlend-aasland
added a commit
that referenced
this pull request
Jun 13, 2023
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent exceptions from possibly being overwritten in case of multiple
failures.