gh-105375: Improve error handling in _ctypes #105593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent repeated PyLong_FromVoidPtr() from possibly overwriting the current exception.
erlend-aasland
added
needs backport to 3.11
18 tasks
sobolevn
reviewed
Jun 10, 2023
erlend-aasland
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 00461fa 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
sobolevn
approved these changes
Jun 11, 2023
|
Argh, the refleaks in |
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2023
Prevent repeated PyLong_FromVoidPtr() from possibly overwriting the current exception. (cherry picked from commit e8998e4) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2023
Prevent repeated PyLong_FromVoidPtr() from possibly overwriting the current exception. (cherry picked from commit e8998e4) Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
|
GH-105663 is a backport of this pull request to the 3.12 branch. |
|
GH-105664 is a backport of this pull request to the 3.11 branch. |
erlend-aasland
added a commit
that referenced
this pull request
Jun 11, 2023
erlend-aasland
added a commit
that referenced
this pull request
Jun 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent repeated PyLong_FromVoidPtr() from possibly overwriting the
current exception.