Skip to content

gh-105557: Remove duplicate sqlite3 test method #105558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

gh-105557: Remove duplicate sqlite3 test method #105558

merged 1 commit into from
Jun 9, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 9, 2023 •
edited by bedevere-bot
Loading

test_func_return_too_large_int() was defined twice.
Keep only the redefined method, as that also checks the tracebacks.

@erlend-aasland
pythongh-105557: Remove duplicate sqlite3 test method
be2d004 
test_func_return_too_large_int() was defined twice.
Keep only the redefined method, as that also checks the tracebacks.
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2023
Closed
@erlend-aasland erlend-aasland merged commit b8fa7bd into python:main Jun 9, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite/test-no-test branch June 9, 2023 13:37
@erlend-aasland erlend-aasland linked an issue Jun 9, 2023 that may be closed by this pull request
test_sqlite3.test_userfunctions redefines test_func_return_too_large_int() method #105557
Closed
@bedevere-bot
Copy link

GH-105561 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 9, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
@erlend-aasland @miss-islington
pythongh-105557: Remove duplicate sqlite3 test method (pythonGH-105558)
6a53ab9 
test_func_return_too_large_int() was defined twice.
Keep only the redefined method, as that also checks the tracebacks.
(cherry picked from commit b8fa7bd)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105562 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 9, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2023
@erlend-aasland @miss-islington
pythongh-105557: Remove duplicate sqlite3 test method (pythonGH-105558)
a00f3d4 
test_func_return_too_large_int() was defined twice.
Keep only the redefined method, as that also checks the tracebacks.
(cherry picked from commit b8fa7bd)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
@miss-islington @erlend-aasland
[3.11] gh-105557: Remove duplicate sqlite3 test method (GH-105558) (#…
6dcbd50 
…105562)

test_func_return_too_large_int() was defined twice.
Keep only the redefined method, as that also checks the tracebacks.
(cherry picked from commit b8fa7bd)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 9, 2023
@miss-islington @erlend-aasland
[3.12] gh-105557: Remove duplicate sqlite3 test method (GH-105558) (#…
bc365da 
…105561)

test_func_return_too_large_int() was defined twice.
Keep only the redefined method, as that also checks the tracebacks.
(cherry picked from commit b8fa7bd)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_sqlite3.test_userfunctions redefines test_func_return_too_large_int() method
3 participants
@erlend-aasland @miss-islington @bedevere-bot