Skip to content

bpo-44185: Added close() to mock_open __exit__ #26902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 11, 2023
Merged

bpo-44185: Added close() to mock_open __exit__ #26902

merged 10 commits into from
Jun 11, 2023

Conversation

samety
Copy link
Contributor

@samety samety commented Jun 24, 2021 •
edited by bedevere-bot
Loading

@samety samety requested a review from cjw296 as a code owner June 24, 2021 19:02
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@samety

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

github-actions bot commented Aug 7, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 7, 2021
MaxwellDupre
MaxwellDupre approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me.

@williamsjoblom williamsjoblom mannequin mentioned this pull request Apr 10, 2022
Closed
@tirkarthi tirkarthi self-requested a review May 21, 2022 06:58
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 10, 2022
@cjw296
Copy link
Contributor

cjw296 commented Dec 27, 2022

Let's discuss more on #88351.

@cjw296 cjw296 linked an issue Jun 9, 2023 that may be closed by this pull request
mock_open file handle __exit__ does not call close #88351
Closed
@cjw296 cjw296 self-requested a review June 9, 2023 13:25
cjw296
cjw296 requested changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@cjw296 cjw296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you fix the docs failure coming from bad ReST in the NEWS entry.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@samety
Copy link
Contributor Author

samety commented Jun 9, 2023

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@cjw296: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from cjw296 June 9, 2023 18:12
@cjw296 cjw296 merged commit 3f7c081 into python:main Jun 11, 2023
@samety samety deleted the bugfix-issue-44185-mockopen-exit branch December 17, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjw296 cjw296 cjw296 approved these changes

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@tirkarthi tirkarthi Awaiting requested review from tirkarthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mock_open file handle __exit__ does not call close
6 participants
@samety @the-knights-who-say-ni @cjw296 @bedevere-bot @MaxwellDupre @ezio-melotti