Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement] Align object addresses in the Descriptor HowTo Guide #113625

Closed
dsardelic opened this issue Jan 1, 2024 · 1 comment
Closed

[improvement] Align object addresses in the Descriptor HowTo Guide #113625

dsardelic opened this issue Jan 1, 2024 · 1 comment
Assignees
@rhettinger
Labels
docs Documentation in the Doc dir

Comments

@dsardelic
Copy link

dsardelic commented Jan 1, 2024 •
edited by bedevere-app bot

Documentation

In the Functions and methods chapter of this wonderful guide there is an inconsistency between object addresses in the provided code examples and outputs.

Current outputs for d.f and d.f.__self__ are <bound method D.f of <__main__.D object at 0x00B18C90>> and <__main__.D object at 0x1012e1f98> respectively. These two addresses should in fact be identical.

Linked PRs
@dsardelic dsardelic added the docs Documentation in the Doc dir label Jan 1, 2024
@rhettinger rhettinger self-assigned this Jan 8, 2024
rhettinger added a commit to rhettinger/cpython that referenced this issue Jan 10, 2024
@rhettinger
pythongh-113625: Align object addresses in the Descriptor HowTo Guide
0f5cd2b
@bedevere-app bedevere-app bot mentioned this issue Jan 10, 2024
Merged
ambv pushed a commit that referenced this issue Jan 10, 2024
@rhettinger
gh-113625: Align object addresses in the Descriptor HowTo Guide (#113894
901a971 
)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 10, 2024
@rhettinger @miss-islington
pythongh-113625: Align object addresses in the Descriptor HowTo Guide (…
49eda2b 
…pythonGH-113894)

(cherry picked from commit 901a971)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Jan 10, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 10, 2024
@rhettinger @miss-islington
pythongh-113625: Align object addresses in the Descriptor HowTo Guide (…
583b0aa 
…pythonGH-113894)

(cherry picked from commit 901a971)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue Jan 10, 2024
Merged
ambv pushed a commit that referenced this issue Jan 10, 2024
@miss-islington @rhettinger
[3.11] gh-113625: Align object addresses in the Descriptor HowTo Guide (
6e21c59 
GH-113894) (#113923)

gh-113625: Align object addresses in the Descriptor HowTo Guide (GH-113894)
(cherry picked from commit 901a971)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
ambv pushed a commit that referenced this issue Jan 10, 2024
@miss-islington @rhettinger
[3.12] gh-113625: Align object addresses in the Descriptor HowTo Guide (
3fc45e6 
GH-113894) (#113922)

gh-113625: Align object addresses in the Descriptor HowTo Guide (GH-113894)
(cherry picked from commit 901a971)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
@hugovk
Copy link
Member

hugovk commented Jan 11, 2024

Thanks for the report, this has now been fixed.

@hugovk hugovk closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhettinger rhettinger

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @rhettinger @dsardelic