Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95778: add doc missing in some places #100627

Merged
merged 2 commits into from Dec 30, 2022

Conversation

merwok
Copy link
Member

@merwok merwok commented Dec 30, 2022

Copy link
Member

@gpshead gpshead left a comment

We truly have things documented in too many places...

@merwok
Copy link
Member Author

merwok commented Dec 30, 2022

I intend to make another issue to discuss adding notes somewhere (devguide and initconfig.c file?), sorting options in the same order everywhere, formatting in a way that makes it easy to copy-paste between the locations, and reformatting to make help output a bit shorter.

Or… maybe it’s time to create one source file that gets mogrified into reST, C and roff formats and automatically included.

@merwok merwok added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Dec 30, 2022
@miss-islington miss-islington merged commit 4652182 into python:main Dec 30, 2022
17 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Dec 30, 2022

Thanks @merwok for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10, 3.11.
🐍🍒🤖

@merwok merwok deleted the complete-doc-int-max-str-digits branch Dec 30, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Dec 30, 2022

Sorry, @merwok, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 46521826cb1883e29e4640f94089dd92c57efc5b 3.10

@bedevere-bot
Copy link

bedevere-bot commented Dec 30, 2022

GH-100628 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Dec 30, 2022

Sorry @merwok, I had trouble checking out the 3.9 backport branch.
Please retry by removing and re-adding the "needs backport to 3.9" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 46521826cb1883e29e4640f94089dd92c57efc5b 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2022
(cherry picked from commit 4652182)

Co-authored-by: Éric <earaujo@caravan.coop>
@miss-islington
Copy link
Contributor

miss-islington commented Dec 30, 2022

Sorry, @merwok, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 46521826cb1883e29e4640f94089dd92c57efc5b 3.8

@miss-islington
Copy link
Contributor

miss-islington commented Dec 30, 2022

Sorry @merwok, I had trouble checking out the 3.7 backport branch.
Please retry by removing and re-adding the "needs backport to 3.7" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 46521826cb1883e29e4640f94089dd92c57efc5b 3.7

miss-islington added a commit that referenced this pull request Dec 30, 2022
(cherry picked from commit 4652182)

Co-authored-by: Éric <earaujo@caravan.coop>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2020-10735: Prevent DoS by large int<->str conversions
4 participants