Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: promote PropsTaintStep to a PreCallGraphStep #15221

Merged
merged 3 commits into from Jan 10, 2024
Merged

JS: promote PropsTaintStep to a PreCallGraphStep #15221

merged 3 commits into from Jan 10, 2024

Conversation

erik-krogh
Copy link
Contributor

Fixes #15207

Evaluations (nightly, default) look good.
No impact on performance.
New call-edges and new results, all of which LGTM.

@github-actions github-actions bot added the JS label Jan 4, 2024
@erik-krogh erik-krogh marked this pull request as ready for review January 9, 2024 21:32
@erik-krogh erik-krogh requested a review from a team as a code owner January 9, 2024 21:32
asgerf
asgerf previously approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

javascript/ql/lib/semmle/javascript/frameworks/React.qll Outdated Show resolved Hide resolved
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Jan 10, 2024
@erik-krogh @asgerf
rename PropsTaintStep to PropsFlowStep
3000b4b 
Co-authored-by: Asger F <asgerf@github.com>
@erik-krogh erik-krogh merged commit 77b0c7f into github:main Jan 10, 2024
12 checks passed
@erik-krogh erik-krogh mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

Assignees
No one assigned
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Taint Tracking of Function Passed Through JSX Attributes
2 participants
@erik-krogh @asgerf