Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Fix upgrade delete directives #15241

Merged
merged 1 commit into from Jan 8, 2024
Merged

C++: Fix upgrade delete directives #15241

merged 1 commit into from Jan 8, 2024
+4 −0

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Jan 5, 2024

This PR adds missing delete directives in upgrade and downgrade scripts.

@github-actions github-actions bot added the C++ label Jan 5, 2024
@cklin cklin marked this pull request as ready for review January 5, 2024 22:28
@cklin cklin requested a review from a team as a code owner January 5, 2024 22:28
MathiasVP
MathiasVP approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@cklin cklin merged commit d7e22b2 into main Jan 8, 2024
13 checks passed
@cklin cklin deleted the cklin/upgrade-delete-fixes-cpp branch January 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cklin @MathiasVP