Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data flow: Remove column from mayBenefitFromCallContext #15260

Merged
merged 1 commit into from Jan 10, 2024
Merged

Data flow: Remove column from mayBenefitFromCallContext #15260

merged 1 commit into from Jan 10, 2024
+85 −126

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 9, 2024 •
edited

Removes a redundant column from mayBenefitFromCallContext, and additionally makes mayBenefitFromCallContext and viableImplInCallContext optional in the API.

@hvitved hvitved force-pushed the dataflow/may-benefit-from-cctx-simplify branch from c0c2330 to f90201e Compare January 9, 2024 10:35
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jan 10, 2024
@hvitved hvitved marked this pull request as ready for review January 10, 2024 08:33
@hvitved hvitved requested review from a team as code owners January 10, 2024 08:33
aschackmull
aschackmull approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

owen-mc
owen-mc approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go LGTM

@hvitved hvitved merged commit c9cf2a8 into github:main Jan 10, 2024
55 checks passed
@hvitved hvitved deleted the dataflow/may-benefit-from-cctx-simplify branch January 10, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschackmull aschackmull aschackmull approved these changes

@owen-mc owen-mc owen-mc approved these changes

Assignees
No one assigned
Labels
C# C++ DataFlow Library documentation Go Java no-change-note-required This PR does not need a change note Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hvitved @aschackmull @owen-mc