Java: Improve Regex flag parsing #15244
Open
+60
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - Flag `d` not being recognized - Syntax for disabling flags (`-`) not being recognized - Non-capturing group with flags erroneously containing `:` as literal
Marcono1234
commented
Jan 6, 2024
| @@ -930,13 +941,13 @@ class Regex extends RegexString { | |||
|
|
|||
| /** | |||
| * Gets a mode (if any) of this regular expression. Can be any of: | |||
| * DEBUG | |||
There was a problem hiding this comment.
Removed this DEBUG because it does not seem to be a possible value.
| @@ -510,9 +513,15 @@ abstract class RegexString extends StringLiteral { | |||
| * ``` | |||
| */ | |||
| private predicate flag(string c) { | |||
There was a problem hiding this comment.
Probably out of scope, but this predicate might not behave as desired when the flags of a group don't affect the whole pattern, e.g. for a(?i:b) it would have the flag i as result even though this only affects the b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
dnot being recognized-) not being recognized:as literalAny feedback is appreciated! Especially if I overlooked or failed to consider something.
I am not sure if this change is also relevant for the regex libraries of the other languages.