Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Update Kernel.qll to include Object.send aliases #15203

Merged
merged 2 commits into from Jan 8, 2024
Merged

Ruby: Update Kernel.qll to include Object.send aliases #15203

merged 2 commits into from Jan 8, 2024

Conversation

pwntester
Copy link
Contributor

Add public_send and __send__ as Code Injection sinks as proposed by @vcsjones

@pwntester
Update Kernel.qll to include send aliases
2964aef 
Add `public_send` and `__send__` as Code Injection sinks as proposed by @vcsjones
@pwntester pwntester requested a review from a team as a code owner December 28, 2023 18:09
@github-actions github-actions bot added the Ruby label Dec 28, 2023
@alexrford alexrford added the no-change-note-required This PR does not need a change note label Jan 2, 2024
alexrford
alexrford reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an autoformat suggestion to fix the compilation check.

ruby/ql/lib/codeql/ruby/frameworks/core/Kernel.qll Outdated Show resolved Hide resolved
@pwntester @alexrford
Apply suggestions from code review
dbefc13 
Co-authored-by: Alex Ford <alexrford@users.noreply.github.com>
@pwntester pwntester changed the title Update Kernel.qll to include Object.send aliases Ruby: Update Kernel.qll to include Object.send aliases Jan 8, 2024
alexrford
alexrford approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexrford alexrford merged commit ef8ca55 into github:main Jan 8, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrford alexrford alexrford approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pwntester @alexrford