Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Changelogs for 2.15.5 #15279

Open
wants to merge 2 commits into
base: codeql-cli-2.15.5
Choose a base branch
from
Open

Conversation

turbo
Copy link
Member

@turbo turbo commented Jan 10, 2024

  • Add the changelog for the current version
  • Apply fixes to other changelogs (sometimes the security coverage section wasn't added)

@turbo turbo self-assigned this Jan 10, 2024
@turbo turbo requested a review from saritai January 10, 2024 12:06
@@ -14,7 +14,7 @@ This is an overview of changes in the CodeQL CLI and relevant CodeQL query and l
Security Coverage
-----------------

CodeQL 2.10.0 runs a total of 339 security queries when configured with the Default suite (covering 142 CWE). The Extended suite enables an additional 104 queries (covering 30 more CWE). 4 security queries have been added with this release.
CodeQL 2.10.0 runs a total of 339 security queries when configured with the Default suite (covering 142 CWE). The Extended suite enables an additional 104 queries (covering 30 more CWE). A list of queries for each suite and language `is available here <https://docs.github.com/en/code-security/code-scanning/managing-your-code-scanning-configuration/codeql-query-suites#queries-included-in-the-default-and-security-extended-query-suites>`__. 4 security queries have been added with this release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be adding this link to old change logs. We certainly don't list the queries available for CodeQL 2.10.0 anywhere.

It might make more sense to add this only to the doc for the current release, and always to remove it from the previous release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move it to the index page instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like a much better idea 👍🏻

@saritai
Copy link
Contributor

saritai commented Jan 10, 2024

@turbo Just discussed this with Felicity who has been working on the 2.16.0 docs release (this is a unique situation where we are publishing them so close together since 2.15.5 just wrapped up). We were wondering whether it would be easier to wait till tomorrow, when 2.16.0 is scheduled to release, and then remake the PR to publish both 2.15.5 and 2.16.0 changelogs at once? cc @felicitymay

@turbo
Copy link
Member Author

turbo commented Jan 10, 2024

@saritai Sure! I can rerun again after 2.16 is published, it will then include both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants