Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webhook] [Framework] Added missing XML attribute in config XSD #52978

Merged
merged 1 commit into from Dec 9, 2023

Conversation

TimoBakx
Copy link
Member

@TimoBakx TimoBakx commented Dec 9, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

The XML schema definition was missing the type attribute for the webhook routing.

This attribute is necessary to identify the correct parser and remote event consumers.

In YAML and PHP, it exists and works:

framework:
    webhook:
        routing:
            mailer: # <-- this identifier
                service: #...
                secret: #...
        use App\Webhook\MailerWebhookParser;
        use Symfony\Config\FrameworkConfig;

        return static function (FrameworkConfig $frameworkConfig): void {
            $webhookConfig = $frameworkConfig->webhook();
            $webhookConfig
                ->routing('mailer') // <-- this parameter
                ->service('mailer.webhook.request_parser.mailgun')
                ->secret('%env(MAILER_MAILGUN_SECRET)%')
            ;
        };

#SymfonyHackday

@carsonbot carsonbot added this to the 6.3 milestone Dec 9, 2023
@TimoBakx TimoBakx changed the title [Webhook] Added missing XML attribute in config XSD [Webhook] [Framework] Added missing XML attribute in config XSD Dec 9, 2023
@fabpot
Copy link
Member

fabpot commented Dec 9, 2023

Thank you @TimoBakx.

@fabpot fabpot merged commit 27bc8d6 into symfony:6.3 Dec 9, 2023
8 of 9 checks passed
@TimoBakx TimoBakx deleted the webhook-added-missing-xml-attribute branch December 9, 2023 18:03
This was referenced Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants