Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113878: Add doc parameter to dataclasses.field #114051

Merged
merged 5 commits into from
Sep 27, 2024
Merged

gh-113878: Add doc parameter to dataclasses.field #114051

merged 5 commits into from
Sep 27, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 14, 2024 •
edited by github-actions bot
Loading

@sobolevn sobolevn requested a review from ericvsmith as a code owner January 14, 2024 08:44
@bedevere-app bedevere-app bot mentioned this pull request Jan 14, 2024
Closed
@ericvsmith ericvsmith self-assigned this Jan 14, 2024
@sobolevn
Copy link
Member Author

@ericvsmith I resolved conflicts and merged main :)

@bedevere-app
Copy link

bedevere-app bot commented Feb 26, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@sobolevn
Copy link
Member Author

I have made the requested changes; please review again

@sobolevn sobolevn requested a review from ericvsmith February 26, 2024 16:34
ericvsmith
ericvsmith requested changes Mar 18, 2024
View reviewed changes
@sobolevn
Copy link
Member Author

Thanks, fair comment! I've updated the docs.

@sobolevn
Copy link
Member Author

sobolevn commented Aug 1, 2024

I rebased and updated tests.

@sobolevn sobolevn requested a review from ericvsmith September 24, 2024 07:13
sobolevn
sobolevn commented Sep 25, 2024
View reviewed changes
@ericvsmith
Copy link
Member

I was discussing this at the core sprint, and I think I'd prefer to see __slots__ be a tuple of str's if no docs are used. Only switch to a dict if there's at least one doc= specified.

@sobolevn
Copy link
Member Author

Done! 👍

ericvsmith
ericvsmith approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@ericvsmith ericvsmith merged commit 9c7657f into python:main Sep 27, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@ericvsmith ericvsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @ericvsmith