do not mock the ContainerInterface #53535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jan 13, 2024
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 7.1 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
derrabus
reviewed
Jan 13, 2024
| use Symfony\Component\HttpKernel\CacheWarmer\WarmableInterface; | ||
| use Symfony\Component\Routing\RouterInterface; | ||
|
|
||
| class RouterCacheWarmerTest extends TestCase | ||
| { | ||
| public function testWarmUpWithWarmableInterfaceWithBuildDir() | ||
| { | ||
| $containerMock = $this->getMockBuilder(ContainerInterface::class)->onlyMethods(['get', 'has'])->getMock(); | ||
| $containerMock = new ContainerBuilder(); |
There was a problem hiding this comment.
The variable name is not accurate anymore. Moreover, do we need a builder here?
Suggested change
| $containerMock = new ContainerBuilder(); | |
| $container = new Container(); |
xabbuh
force-pushed
the
container-interface-mock
branch
2 times, most recently
from
96b6b17 to
2960f36
Compare
javiereguiluz
approved these changes
Jan 16, 2024
xabbuh
force-pushed
the
container-interface-mock
branch
from
2960f36 to
4564a68
Compare
xabbuh
force-pushed
the
container-interface-mock
branch
from
4564a68 to
016e6d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.