[Form] Fix assigning data in PostSetDataEvent and PostSubmitEvent
#53381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Jan 3, 2024
| @@ -11,7 +11,6 @@ | |||
|
|
|||
| namespace Symfony\Component\Form\Event; | |||
|
|
|||
| use Symfony\Component\Form\Exception\BadMethodCallException; | |||
There was a problem hiding this comment.
It's not present in PostSubmitEvent.
There was a problem hiding this comment.
It's not present in PostSubmitEvent.
No, but this is about PostSetDataEvent and it is in the comment for the next major:
// throw new BadMethodCallException('Form data cannot be changed during "form.post_set_data", you should use "form.pre_set_data" instead.');There was a problem hiding this comment.
What I mean is that there's the same code in PostSubmitEvent without the import 😅
There was a problem hiding this comment.
Oh I would add the import then 👍
There was a problem hiding this comment.
I'd follow what fabbot wants on this one, because this will come up again otherwise.
But we should then be careful when merging up to not remove the use in 7.0
OskarStark
changed the title
PostSetDataEvent and PostSubmitEvent
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #51043 where we changed the behavior on 6.4 since we don't assign the data property anymore.
cc @HeahDude