docs(docs-infra): change deprecated modules' headers' style in the hover state #54337
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed aio for d7c29d9 to: https://ng-dev-previews-fw--pr-angular-angular-54337-aio-fc30djq7.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Hi, thank you for the improvement. Could you take a look at the failing linting job. We have specific commit message guidelines. Could you reword you commit to |
Ahmed-Hakeem
force-pushed
the
patch-2
branch
2 times, most recently
from
8989c2a
to
b4c9e79
Compare
Ahmed-Hakeem
changed the title
My pleasure Thank you for your help ❤️. Now everything is perfect. |
Ahmed-Hakeem
changed the title
AndrewKushnir
approved these changes
Feb 9, 2024
AndrewKushnir
added
action: merge
|
This PR was merged into the repository by commit 5890f05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of style specificity, deprecated modules' headers don't have their styles in runtime, especially when hovering over the header.
Before hovering, it has a line-through style.
After hovering, it returns back to the underline because of its inconvenient style specificity.
