[Messenger] the 'use_notify' option is on the factory, not on the postgres connection #53960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failures seem unrelated to my changes. |
carsonbot
changed the title
nicolas-grekas
approved these changes
Feb 22, 2024
|
Thank you @dbu. |
This was referenced Feb 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use_notifyfrom PostgreSqlConnection::DEFAULT_OPTIONS a BC break? then we would have to leave it there but comment that it is unusedI was debugging messenger not seeing updates and stumbled over this. I guess things changed before release or had been different in older versions.
(side note: listen/notify does not work for me when using the symfony skeleton setup, so i had to disable the mechanism. i assume it is cheaper to try to install the listener on each
getthan querying the messages table? a little bit of documentation as to why the functionality is used would not hurt)