Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ErrorHandler] return the unchanged text if preg_replace_callback() fails #53967

Merged
merged 1 commit into from Feb 20, 2024
Merged

[ErrorHandler] return the unchanged text if preg_replace_callback() fails #53967

merged 1 commit into from Feb 20, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 16, 2024

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #51290
License MIT

@xabbuh xabbuh requested a review from yceruto as a code owner February 16, 2024 11:22
@carsonbot carsonbot added this to the 5.4 milestone Feb 16, 2024
@xabbuh xabbuh mentioned this pull request Feb 16, 2024
Closed
nicolas-grekas
nicolas-grekas approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered if we could make the regexp do less backtracking, but I'm not sure how. LGTM if the backtracking doesn't cause any other side effect.

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 9c6da5e into symfony:5.4 Feb 20, 2024
8 of 11 checks passed
@xabbuh xabbuh deleted the issue-51290 branch February 20, 2024 18:12
This was referenced Feb 27, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug ErrorHandler Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xabbuh @nicolas-grekas @carsonbot