[Uid] Optimize UuidV4 generation #53963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would be nice to add more comments in the code to explain the code |
|
@lyrixx |
stof
reviewed
Feb 16, 2024
Merged
nicolas-grekas
approved these changes
Feb 19, 2024
fabpot
added a commit
that referenced
this pull request
Feb 20, 2024
This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [Uid] Minor updates | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix # | License | MIT Some minor things i found while [playing with UuidV4](#53963). In those places, calling the polyfill cost us a lot of operations, as we already did most of the checks, might as well running directly the expected code. Full disclosure: at first, i wanted to remove entirely the uuid_ pecl / polyfill dependencies. But uuid_create is still used for UuidV1 / V7 generation, and more perorfmant than the polyfill. After this PR, the extension (or the polyfills) are still used via 2 methods: `uuid_create` and `uuid_compare`. Commits ------- a2e5dca [Uid] Minor updates
fabpot
approved these changes
Feb 20, 2024
fabpot
force-pushed
the
feat/optimize-uuidv4
branch
from
fdff529 to
7b5c57b
Compare
|
Thank you @smnandre. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to optimize as much as I could the UuidV4 generation.
According to local tests, the code is now between
35%and40%faster.(But to be fair... we are talking nanoseconds here 😅)
Thanks @nicolas-grekas for the help in this
uselessfun quest 😃--
--> Bench (& results): https://github.com/smnandre/uuid-bench