Cast env vars to null or bool when referencing them using #[Autowire(env: '...')] depending on the signature of the corresponding parameter
#53971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
changed the title
ruudk
force-pushed
the
add-bool-env-processor
branch
from
21386a2 to
6b838ba
Compare
|
I know this is not a "good" practice, but i have use multiple times the following method to "feature-flag" some services. SERVICE_SUPER_KEY=my_super_key[Autowire(env: 'SERVICE_SUPER_KEY')] bool $superServiceEnabledWith your PR that would create the opposite problem of your example :| 🤷 |
|
@smnandre your use case could be covered if the code for the bool processor were doing this in EnvVarProcessor: filter_var($env, \FILTER_VALIDATE_BOOL, \FILTER_NULL_ON_FAILURE) ?? filter_var($env, \FILTER_VALIDATE_INT, \FILTER_NULL_ON_FAILURE) ?? filter_var($env, \FILTER_VALIDATE_FLOAT, \FILTER_NULL_ON_FAILURE) ?? trueWorth considering? |
|
Similarly, we could also add |
As i said, this usage was a bit hacky, so we can "ignore it", but that will deserve some warning / upgrade mentions, no ? |
|
It makes sense to me but the changelog should explain a bit more the change and the new behavior. |
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
changed the title
#[Autowire(env: '...')] depending on the signature of the corresponding parameter
nicolas-grekas
force-pushed
the
add-bool-env-processor
branch
from
6b838ba to
83c82e0
Compare
…them using `#[Autowire(env: '...')]` depending on the signature of the corresponding parameter
nicolas-grekas
force-pushed
the
add-bool-env-processor
branch
from
83c82e0 to
5890327
Compare
nicolas-grekas
approved these changes
Apr 11, 2024
nicolas-grekas
added
❄️ Feature Freeze
fabpot
approved these changes
Apr 13, 2024
carsonbot
changed the title
#[Autowire(env: '...')] depending on the signature of the corresponding parameter#[Autowire(env: '...')] depending on the signature of the corresponding parameter
|
Thank you @ruudk. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #53918
This PR automatically adds
boolEnvironment Variable Processors on#[Autowire(env: 'KEY')] bool $keyarguments.The idea behind this, is to prevent mistakes being made. If you omit the
boolenv var processor, passingKEY=falsewill become true-ish and thus mark$keyastrue.With the
boolenv processor,KEY=falsebecomesfalse.It also automatically adds the
default::prefix if the default value of an argument isnull.