[Messenger] Fix PHPDoc #53914
[Messenger] Fix PHPDoc #53914
Conversation
| * @return StampInterface[]|StampInterface[][] The stamps for the specified FQCN, or all stamps by their class name | ||
| * | ||
| * @psalm-return ($stampFqcn is string : array<class-string<StampInterface>, list<StampInterface>> ? list<TStamp>) | ||
| * @return ($stampFqcn is string ? list<TStamp> : array<class-string<StampInterface>, list<StampInterface>>) The stamps for the specified FQCN, or all stamps by their class name |
There was a problem hiding this comment.
why merge return and psalm-return? I think we didn't anywhere yet so we shouldn't start in a PR like that
There was a problem hiding this comment.
i thought it made psalm trip, but no, it still errors. We should template stamps property still, but that's not a public API concern. Also i was unsure how to do it 😅
in fact we use both conditional @return and @psalm-return. Merge across the board welcome i think.
https://github.com/search?q=repo%3Asymfony%2Fsymfony+%22%40return+%28%22&type=code
https://github.com/search?q=repo%3Asymfony%2Fsymfony+%22%40psalm-return+%28%22&type=code
There was a problem hiding this comment.
I don't think we use conditional types in @return
There was a problem hiding this comment.
There was a problem hiding this comment.
i dont mind, you can cherry pick a2c660b
https://psalm.dev/docs/annotating_code/type_syntax/conditional_types/
https://psalm.dev/r/76330fe331