[Process] Fix executable finder when the command starts with a dash #53481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kayw-geek
commented
Jan 10, 2024
•
kayw-geek
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #53479 |
| License | MIT |
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "bug fixes". Cheers! Carsonbot |
kayw-geek
changed the title
xabbuh
requested changes
Jan 10, 2024
carsonbot
changed the title
carsonbot
changed the title
nicolas-grekas
changed the title
nicolas-grekas
requested review from
lyrixx,
yceruto,
chalasr and
dunglas
as code owners
nicolas-grekas
force-pushed
the
bugfix/fix-exec-command-v-with-other-option
branch
from
819ec41
to
8ceaa8e
Compare
|
Thank you @kayw-geek. |
This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 20, 2024
This PR was submitted for the 7.1 branch but it was merged into the 6.4 branch instead. Discussion ---------- [Process] Fix the `command -v` exception | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53479 | License | MIT This PR is a continuation of the fixes made in PR #53481 to address the issue. The previous PR partially addressed the problem, but after further review and testing, it was determined that additional changes were needed. Fix the `command -v` exception when the command option with a dash prefix. Commits ------- 2b73f0c Fix the `command -v` exception when the command option with a dash prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.