Add missed stream argument
#111775
Add missed stream argument
#111775
Conversation
|
Thanks @gaogaotiantian for tracking down the origin of the issue. Although that's day 1 for this class, the code is derived from resources.py in that commit. In the upstream implementation (which probably has better fidelity of the history of this change), that file is skipped for coverage checks. That module was provided as an illustration of the lowest level interfaces required to supply If we accept this change (and we probably should), we'll want to make sure it gets ported upstream. |
|
I've cherry-picked this change into python/importlib_resources and released it as 6.1.1. This change will make it into CPython in due time. If you want to author a news fragment, I'll merge this change. |
jaraco
added
skip issue
needs backport to 3.11
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
My question is, if no one has used this piece of code for 2 years and it's not documented at all, do we still need it in CPython repo? |
Probably not, but to remove it will require a deprecation and we'll want to present that deprecation first in importlib_resources. Feel free to propose that there. In the meantime, it makes sense to merge the bugfix. |
|
Oh, I thought removing code that we never documented does not require anything. But yeah, the fix itself definitely makes sense. |
|
I have made the requested changes; please review again |
|
Is something required of me here? |
…29224 https://build.opensuse.org/request/show/1129224 by user dirkmueller + anag+factory - update to 6.1.1: * Added missed stream argument in simple.ResourceHandle. Ref python/cpython#111775. * MultiplexedPath now expects Traversable paths. String arguments to MultiplexedPath are now deprecated. * Enabled support for resources in namespace packages in zip files. (#287) - Update to v5.10.1 * #259: files no longer requires the anchor to be specified and can infer the anchor from the caller's scope (defaults to the caller's module). * bpo-41490: contents is now also more aggressive about consuming * #110 and bpo-41490: path method is more aggressive about releasing handles to zipfile objects early, enabling use-cases like certifi to leave the context open but delete the * Package no longer exposes importlib_resources.__version__. Users that w
No description provided.