Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable #115449

Merged
merged 3 commits into from
Feb 14, 2024
Merged

gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable #115449

merged 3 commits into from
Feb 14, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 14, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Feb 14, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Feb 14, 2024
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@erlend-aasland

This comment was marked as outdated.

Sign in to view
@bedevere-bot

This comment was marked as outdated.

Sign in to view
@AlexWaygood AlexWaygood mentioned this pull request Feb 14, 2024
Closed
@erlend-aasland
Copy link
Contributor Author

I think I prefer this fix.

AlexWaygood
AlexWaygood approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in #115448 (comment). This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test. But either is probably fine; no strong preference :)

@AlexWaygood
Copy link
Member

This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test.

You could maybe add a comment noting that the imports need to be in precisely that order

@erlend-aasland
Copy link
Contributor Author

You could maybe add a comment noting that the imports need to be in precisely that order

Yes, that seems fair to the future reader.

@erlend-aasland @AlexWaygood
Update Lib/test/test_dbm_sqlite3.py
767c8b0 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aasland erlend-aasland enabled auto-merge (squash) February 14, 2024 12:28
@erlend-aasland
Copy link
Contributor Author

Thanks for the review(s), Alex!

@AlexWaygood
Copy link
Member

No worries!

@erlend-aasland erlend-aasland mentioned this pull request Feb 14, 2024
Merged
@encukou
Copy link
Member

encukou commented Feb 14, 2024

!buildbot AMD64 RHEL7

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit d9a099c 🤖

The command will test the builders whose names match following regular expression: AMD64 RHEL7

The builders matched are:

  • AMD64 RHEL7 LTO PR
  • AMD64 RHEL7 PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 RHEL7 LTO + PGO PR

@erlend-aasland erlend-aasland merged commit 029ec91 into python:main Feb 14, 2024
30 checks passed
@erlend-aasland erlend-aasland deleted the dbm/alt-fix-sqlite3-backend branch February 14, 2024 13:16
@erlend-aasland erlend-aasland mentioned this pull request Feb 14, 2024
Merged
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@erlend-aasland @AlexWaygood @fsc-eriker
pythongh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable (pyt…
642d5f6 
…hon#115449)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @bedevere-bot @AlexWaygood @encukou @serhiy-storchaka