Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40521: Make the empty frozenset per interpreter #21068

Merged
merged 1 commit into from Jun 23, 2020
Merged

bpo-40521: Make the empty frozenset per interpreter #21068

merged 1 commit into from Jun 23, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 23, 2020 •
edited by bedevere-bot

Each interpreter now has its own empty frozenset singleton.

https://bugs.python.org/issue40521

@vstinner vstinner requested a review from rhettinger as a code owner Jun 23, 2020
@vstinner
Copy link
Member Author

vstinner commented Jun 23, 2020

I checked the following tests for reference leaks using "./python -m test -R 3:3": there is no leak.

  • test_setcomps
  • test_set
  • test_atexit
  • test_capi
  • test_threading
  • test_interpreters
  • test__xxsubinterpreters

@vstinner
bpo-40521: Make the empty frozenset per interpreter
f1f85eb 
Each interpreter now has its own empty frozenset singleton.
@vstinner vstinner force-pushed the interp_empty_frozenset branch from 41c66e3 to f1f85eb Compare Jun 23, 2020
@vstinner vstinner merged commit 261cfed into python:master Jun 23, 2020
4 checks passed
@vstinner vstinner deleted the interp_empty_frozenset branch Jun 23, 2020
rhettinger added a commit to rhettinger/cpython that referenced this pull request Jun 23, 2020
@rhettinger
Revert "bpo-40521: Make the empty frozenset per interpreter (pythonGH…
00c029a 
…-21068)"

This reverts commit 261cfed.
vstinner pushed a commit that referenced this pull request Jun 23, 2020
@rhettinger
bpo-40521: Empty frozenset is no longer a singleton (GH-21085)
f9bd05e 
* Revert "bpo-40521: Make the empty frozenset per interpreter (GH-21068)"

This reverts commit 261cfed.

* bpo-40521: Empty frozensets are no longer singletons

* Complete the removal of the frozenset singleton
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@vstinner @fasihahmad
bpo-40521: Make the empty frozenset per interpreter (pythonGH-21068)
ab9f8b9 
Each interpreter now has its own empty frozenset singleton.
fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@rhettinger @fasihahmad
bpo-40521: Empty frozenset is no longer a singleton (pythonGH-21085)
657f2bd 
* Revert "bpo-40521: Make the empty frozenset per interpreter (pythonGH-21068)"

This reverts commit 261cfed.

* bpo-40521: Empty frozensets are no longer singletons

* Complete the removal of the frozenset singleton
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@vstinner @arun-mani-j
bpo-40521: Make the empty frozenset per interpreter (pythonGH-21068)
1334ab4 
Each interpreter now has its own empty frozenset singleton.
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@rhettinger @arun-mani-j
bpo-40521: Empty frozenset is no longer a singleton (pythonGH-21085)
e96c149 
* Revert "bpo-40521: Make the empty frozenset per interpreter (pythonGH-21068)"

This reverts commit 261cfed.

* bpo-40521: Empty frozensets are no longer singletons

* Complete the removal of the frozenset singleton
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot