Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101377: improving test_locale_calendar_formatweekday of calendar #101378

Merged
merged 4 commits into from Mar 15, 2023
Merged

gh-101377: improving test_locale_calendar_formatweekday of calendar #101378

merged 4 commits into from Mar 15, 2023

Conversation

andrehora
Copy link
Contributor

@andrehora andrehora commented Jan 27, 2023 •
edited by bedevere-bot

@bedevere-bot bedevere-bot mentioned this pull request Jan 27, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 27, 2023
@bedevere-bot
Copy link

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 27, 2023 •
edited

All commit authors signed the Contributor License Agreement.
CLA signed

blurb-it bot and others added 2 commits January 27, 2023 18:10
@blurb-it
📜🤖 Added by blurb_it.
c01cec3
@terryjreedy
Update test_calendar.py
7b665ff 
Remove a few cases that I considered excessive.
@terryjreedy terryjreedy self-assigned this Feb 24, 2023
terryjreedy
terryjreedy approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after edit. Will merge.

@terryjreedy terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes type-feature A feature request or enhancement labels Feb 24, 2023
@terryjreedy terryjreedy merged commit 5e0865f into python:main Mar 15, 2023
12 checks passed
@miss-islington
Copy link
Contributor

Thanks @andrehora for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-102713 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2023
@andrehora @blurb-it
@terryjreedy @miss-islington
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
c019bb6 
…ndar (pythonGH-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <andrehora@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Mar 15, 2023
@bedevere-bot
Copy link

GH-102714 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 15, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2023
@andrehora @blurb-it
@terryjreedy @miss-islington
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
3f79894 
…ndar (pythonGH-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <andrehora@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Mar 15, 2023
@miss-islington @andrehora
@blurb-it @terryjreedy
gh-101377: improving test_locale_calendar_formatweekday of calendar (G…
6f4df72 
…H-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <andrehora@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
miss-islington added a commit that referenced this pull request Mar 15, 2023
@miss-islington @andrehora
@blurb-it @terryjreedy
gh-101377: improving test_locale_calendar_formatweekday of calendar (G…
8aa07b9 
…H-101378)

---------

(cherry picked from commit 5e0865f)

Co-authored-by: Andre Hora <andrehora@users.noreply.github.com>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@terryjreedy
Copy link
Member

Thank you Andre. Completed.

@andrehora
Copy link
Contributor Author

Thanks @terryjreedy!

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request Mar 27, 2023
@andrehora @blurb-it
@terryjreedy @Fidget-Spinner
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
669c82a 
…ndar (python#101378)


---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
@andrehora @blurb-it
@terryjreedy @warsaw
pythongh-101377: improving test_locale_calendar_formatweekday of cale…
c2f03e5 
…ndar (python#101378)


---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@terryjreedy terryjreedy

Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrehora @bedevere-bot @miss-islington @terryjreedy