Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-96073: Fix wild replacement in formatannotation #96074

Merged
merged 6 commits into from Oct 7, 2022
Merged

GH-96073: Fix wild replacement in formatannotation #96074

merged 6 commits into from Oct 7, 2022

Conversation

iyume
Copy link
Contributor

@iyume iyume commented Aug 18, 2022 •
edited by bedevere-bot

@bedevere-bot
Copy link

bedevere-bot commented Aug 18, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

sobolevn
sobolevn reviewed Aug 29, 2022
View changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited

Please, don't forget to add news and tests.

I also think that proposed solution can be simplified?

I propose adding a new module to test it, something like:

        new file:   Lib/test/typingdata/__init__.py
        new file:   Lib/test/typingdata/typing.py

In the future we can even more all ann_modules there 🤔

@iyume
Copy link
Contributor Author

iyume commented Aug 29, 2022

@sobolevn I have added some test based on your suggestion.

@gvanrossum gvanrossum removed their request for review Aug 29, 2022
JelleZijlstra
JelleZijlstra reviewed Aug 31, 2022
View changes
Lib/inspect.py Outdated Show resolved Hide resolved
JelleZijlstra
JelleZijlstra reviewed Aug 31, 2022
View changes
Lib/test/typingdata/typing.py Outdated Show resolved Hide resolved
@iyume iyume requested review from JelleZijlstra and removed request for Fidget-Spinner Aug 31, 2022
sobolevn
sobolevn reviewed Aug 31, 2022
View changes
Lib/test/typinganndata/inspect.py Outdated Show resolved Hide resolved
@iyume iyume requested review from sobolevn and removed request for JelleZijlstra Sep 3, 2022
@JelleZijlstra JelleZijlstra merged commit d5fea01 into python:main Oct 7, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 7, 2022

Thanks @iyume for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 7, 2022

GH-98045 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@iyume @miss-islington
pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…
ec569d1 
…honGH-96074)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Oct 7, 2022

GH-98046 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@iyume @miss-islington
pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…
d58c82e 
…honGH-96074)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @iyume
GH-96073: Fix wild replacement in inspect.formatannotation (GH-96074)
107ba92 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @iyume
GH-96073: Fix wild replacement in inspect.formatannotation (GH-96074)
a3a3701 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5fea01)

Co-authored-by: Anh71me <iyumelive@gmail.com>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@iyume @JelleZijlstra @mpage
pythonGH-96073: Fix wild replacement in inspect.formatannotation (pyt…
41b8172 
…hon#96074)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

@sobolevn sobolevn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iyume @bedevere-bot @miss-islington @JelleZijlstra @sobolevn