Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-99276 - Updated Doc/faq/general.rst #101396

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

workingpayload
Copy link

@workingpayload workingpayload commented Jan 28, 2023

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 28, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but:

Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:

Please could you update the PR?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@workingpayload
Copy link
Author

Thanks for the PR, but:

Issue gh-99276 was about adding the https://ir.cwi.nl/pub/18204 article link to that articles section:

Please could you update the PR?

Yeah Sure!!

@workingpayload
Copy link
Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from hugovk Jan 29, 2023
@hugovk
Copy link
Member

hugovk commented Jan 29, 2023

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite
-outdated.
+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was 
+written in 1991 and is now quite outdated.

@workingpayload
Copy link
Author

Rather than adding that extra line, shall we add an inline link?

For example, to add the link around "very first article":

-The very first article about Python was written in 1991 and is now quite
-outdated.
+The `very first article <https://ir.cwi.nl/pub/18204>` about Python was 
+written in 1991 and is now quite outdated.

Yeah sure!!
I'll do that.
Thank you for helping me out.

@workingpayload
Copy link
Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

Doc/faq/general.rst Outdated Show resolved Hide resolved
Doc/faq/general.rst Outdated Show resolved Hide resolved
@workingpayload
Copy link
Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from hugovk Jan 30, 2023
workingpayload and others added 2 commits Jan 30, 2023
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Doc/faq/general.rst Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@workingpayload workingpayload requested a review from hugovk Jan 30, 2023
hugovk
hugovk approved these changes Jan 30, 2023
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants