[3.11] gh-51574: Document behaviour of mkdtemp on 3.11 and lower
#103844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
added
docs
|
In the docs for 3.12, should we add "Changed in version 3.12: the return value is always an absolute path, even if dir is relative"? Would that be a separate PR? |
The note has already been added to the docs for 3.12 as part of #94612: see https://github.com/python/cpython/pull/94612/files#diff-cd9226095497c724772acabf76ce71e39ae2d6ae5cee2a27c9ba22ac541b2f1eR295-R297 The online docs have yet to be updated; they're built every few hours, I think. |
JelleZijlstra
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug has been fixed in 3.12 where
mkdtempdoes not return an absolute path if a relative path is supplied to the dir argument (#94612). However, the bugfix is not suitable to be backported, meaning the bug will not be fixed in the 3.11 branch and lower.We should note the existing behaviour in the docs for the 3.11 branch, so that users are not misinformed about what will happen when the function is called.
Closes #51574