Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument Clinic included return converters hard code use of _return_value #64660

Open
brettcannon opened this issue Jan 31, 2014 · 2 comments
Open

Argument Clinic included return converters hard code use of _return_value #64660

brettcannon opened this issue Jan 31, 2014 · 2 comments
Assignees
@larryhastings
Labels
build The build process and cross-build topic-argument-clinic

Comments

@brettcannon
Copy link
Member

brettcannon commented Jan 31, 2014 •
edited by bedevere-bot

BPO 20461
Nosy @larryhastings

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = None
created_at = <Date 2014-01-31.17:28:47.030>
labels = ['build', 'expert-argument-clinic']
title = 'Argument Clinic included return converters hard code use of ``_return_value``'
updated_at = <Date 2020-03-18.18:40:11.018>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2020-03-18.18:40:11.018>
actor = 'brett.cannon'
assignee = 'larry'
closed = False
closed_date = None
closer = None
components = ['Build', 'Argument Clinic']
creation = <Date 2014-01-31.17:28:47.030>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 20461
keywords = []
message_count = 1.0
messages = ['209808']
nosy_count = 1.0
nosy_names = ['larry']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue20461'
versions = ['Python 3.4']

Linked PRs
@brettcannon
Copy link
Member Author

E.g. NoneType_return_converter assumes _return_value is used in render() although CReturnConverter.declare() stores it in data.return_value and it's a parameter to render().

@brettcannon brettcannon added the build The build process and cross-build label Jan 31, 2014
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
@erlend-aasland erlend-aasland mentioned this issue May 5, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 5, 2023
@erlend-aasland
pythongh-64660: Don't hard-code '_return_value' in AC return converters
acfdab7
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 5, 2023
@erlend-aasland
pythongh-64660: Don't hardcode Argument Clinic return converter resul…
de9dc35 
…t variable name
@erlend-aasland
Copy link
Contributor

See gh-104200 for an improvement. There's still stuff to be done, IMO. For example, return_converter (no underscore prefix!) is also hardcoded several places. There's also the hack mentioned by Brett in the OP.

erlend-aasland added a commit that referenced this issue May 7, 2023
@erlend-aasland
gh-64660: Don't hardcode Argument Clinic return converter result vari…
ac02062 
…able name (#104200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larryhastings larryhastings

Labels
build The build process and cross-build topic-argument-clinic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brettcannon @serhiy-storchaka @erlend-aasland @larryhastings