Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DomCrawler][Form] Fix the exclusion of <template> #53826

Merged
merged 1 commit into from Feb 9, 2024
Merged

[DomCrawler][Form] Fix the exclusion of <template> #53826

merged 1 commit into from Feb 9, 2024

Conversation

mpiot
Copy link
Contributor

@mpiot mpiot commented Feb 7, 2024 •
edited

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53823
License MIT

In the DomCrawler, the way to get fields via xPath avoid to find elements inside a <template> element:

<form>
    <template>
        <input type="text" name="not_selected_because_in_template" />
    </template>

    <input type="text" name="selected_because_out_of_template" />
</form>

But, it appear it also exclude form elements if the <form> is in a <template> (eg: in a <turbo-stream>), that bug-fix keep the previous behavior but allow the following:

<turbo-stream>
    <template>
        <form>
            <input type="text" name="selected_because_in_turbo_stream_1" />
            <input type="text" name="selected_because_in_turbo_stream_2" />
        </form>
    </template>
</turbo-stream>

As mentioned in #53823, an alternative should be to use [not(ancestor::template/ancestor::form)] in the xPath to allow:

<template>
    <form>
        <input type="text" name="selected_because_parent_is_form_1" />
        <input type="text" name="selected_because_parent_is_form_2" />
    </form>
</template>

@carsonbot carsonbot added this to the 6.4 milestone Feb 7, 2024
@carsonbot carsonbot changed the title [DomCrawler] [Form] Fix the exclusion of <template> [DomCrawler][Form] Fix the exclusion of <template> Feb 7, 2024
@nicolas-grekas
Copy link
Member

Thank you @mpiot.

@nicolas-grekas nicolas-grekas merged commit cff8011 into symfony:6.4 Feb 9, 2024
5 of 9 checks passed
This was referenced Feb 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug DomCrawler Form Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpiot @nicolas-grekas @carsonbot