gh-99535: Add test for inheritance of annotations and update documentation #99990
Conversation
LGTM, except one more idea: let's add a note here as well: https://docs.python.org/3/library/typing.html#typing.get_type_hints
I think that the common way to mark version changes is .. versionchanged:: directive.
This will notify users of get_type_hints (who are the most affected) about this.
MonadChains
requested review from
gvanrossum,
Fidget-Spinner,
JelleZijlstra and
AlexWaygood
as code owners
|
| Name | Link |
|---|---|
| 671a262 | |
| https://app.netlify.com/sites/python-cpython-preview/deploys/638fd2b6fb1129000819b84b | |
| https://deploy-preview-99990--python-cpython-preview.netlify.app | |
Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
|
@sobolevn I've added the note to the function. |
| pass | ||
| self.assertEqual(A.__annotations__, {"attr": int}) | ||
| self.assertEqual(B.__annotations__, {}) | ||
| self.assertEqual(C.__annotations__, {"attr" : str}) |
There was a problem hiding this comment.
Why not test D's annotations?
| self.assertEqual(C.__annotations__, {"attr" : str}) | |
| self.assertEqual(C.__annotations__, {"attr": str}) | |
| self.assertEqual(D.__annotations__, {"attr2": int}) |
| @@ -2773,6 +2773,10 @@ Introspection helpers | |||
| .. versionchanged:: 3.9 | |||
| Added ``include_extras`` parameter as part of :pep:`593`. | |||
|
|
|||
| .. versionchanged:: 3.10 | |||
| ``__annotations__`` of a class does not contain anymore the annotations | |||
There was a problem hiding this comment.
Feels weird to mention that here since there's no change to get_type_hints itself.
| Starting from Python 3.10, accessing the annotations | ||
| of a class will not give anymore the ones of its base | ||
| classes. |
There was a problem hiding this comment.
I would say something like this:
Before Python 3.10, accessing __annotations__ on a class that defines no annotations but that has a parent class with annotations would return the parent's __annotations__. In Python 3.10 and newer, the child class's annotations will be an empty dict instead.
Closes #99535.
I've added a simple test for checking that annotations are not inherited by derived classes and update the documentation about annotations
__annotations__are not inherited in 3.10 while they are in 3.8 #99535