Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-24464: Deprecate sqlite3.enable_shared_cache #24008

Merged
merged 10 commits into from Jan 6, 2021
Merged

bpo-24464: Deprecate sqlite3.enable_shared_cache #24008

merged 10 commits into from Jan 6, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Dec 30, 2020 •
edited by bedevere-bot

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Dec 30, 2020

cc @ned-deily, @ronaldoussoren

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Dec 30, 2020

FYI https://sqlite.org/c3ref/enable_shared_cache.html:
"Shared cache is disabled by default. It is recommended that it stay that way. In other words, do not use this routine. This interface continues to be provided for historical compatibility, but its use is discouraged. Any use of shared cache is discouraged."

ZackerySpytz
ZackerySpytz reviewed Dec 31, 2020
View changes
Doc/whatsnew/3.10.rst Outdated
@@ -462,6 +462,14 @@ Deprecated
scheduled for removal in Python 3.12.
(Contributed by Erlend E. Aasland in :issue:`42264`.)

* ``sqlite3.enable_shared_cache`` is now deprecated, scheduled for removal in
Python 3.12. The method is undocumented, and it's use is strongly
Copy link
Contributor

@ZackerySpytz ZackerySpytz Dec 31, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Python 3.12. The method is undocumented, and it's use is strongly
Python 3.12. The method is undocumented, and its use is strongly

It is incorrect to use a contraction here.

Also, it seems that sqlite3.enable_shared_cache is not a method.

Copy link
Contributor Author

@erlend-aasland erlend-aasland Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it seems that sqlite3.enable_shared_cache is not a method.

Correct, it's a built-in function. Good catch.

Copy link
Contributor Author

@erlend-aasland erlend-aasland Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 7d52671. Is the new phrasing acceptable?

Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2020-12-30-14-56-25.bpo-24464.vbNVHe.rst Outdated Show resolved Hide resolved
erlend-aasland and others added 4 commits Dec 31, 2020
@erlend-aasland @ZackerySpytz
Fix typo: it's => its
13a1eb1 
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@erlend-aasland @ZackerySpytz
Add missing punctuation mark.
f93c455 
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@erlend-aasland @ZackerySpytz
Fix typo: it's => its
5fa5918 
Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@erlend-aasland
Address review: it's not a method, it's a built-in function
7d52671
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Dec 31, 2020

PTAL, @ZackerySpytz

@corona10 corona10 requested a review from ronaldoussoren Jan 1, 2021
merwok
merwok reviewed Jan 4, 2021
View changes
Lib/sqlite3/dbapi2.py Show resolved Hide resolved
merwok
merwok reviewed Jan 4, 2021
View changes
Lib/sqlite3/dbapi2.py Outdated Show resolved Hide resolved
merwok
merwok reviewed Jan 4, 2021
View changes
Lib/sqlite3/dbapi2.py Outdated Show resolved Hide resolved
berkerpeksag
berkerpeksag approved these changes Jan 6, 2021
View changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

LGTM!

@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Jan 6, 2021

Thanks, and thanks for the markup fix, @berkerpeksag !

@berkerpeksag
Copy link
Member

@berkerpeksag berkerpeksag commented Jan 6, 2021

All failed tests seem to be unrelated and flaky. Will continue with merge.

@berkerpeksag berkerpeksag merged commit ddb5e11 into python:master Jan 6, 2021
9 of 11 checks passed
@erlend-aasland erlend-aasland deleted the sqlite-shared-cache branch Jan 6, 2021
@erlend-aasland erlend-aasland mentioned this pull request Jan 8, 2021
Merged
m000 pushed a commit to m000/cpython that referenced this issue Jan 29, 2021
@erlend-aasland @m000
bpo-24464: Deprecate sqlite3.enable_shared_cache (pythonGH-24008)
ae4ae40
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 13, 2021
@erlend-aasland @adorilson
bpo-24464: Deprecate sqlite3.enable_shared_cache (pythonGH-24008)
f2c6a84
@erlend-aasland erlend-aasland mentioned this pull request May 9, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request May 9, 2022
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue May 9, 2022
@erlend-aasland
pythongh-92547: Remove deprecated sqlite3 features
8312697 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (pythongh-23163)
- sqlite3.enable_shared_cache (pythongh-24008)

Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this issue May 16, 2022
@erlend-aasland @JelleZijlstra
gh-92547: Remove deprecated sqlite3 features (#92548)
00f22e8 
The following sqlite3 features were deprecated in 3.10, scheduled for
removal in 3.12:

- sqlite3.OptimizedUnicode (gh-23163)
- sqlite3.enable_shared_cache (gh-24008)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Signed-off-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok

@ZackerySpytz ZackerySpytz

@berkerpeksag berkerpeksag

@ronaldoussoren ronaldoussoren

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@erlend-aasland @berkerpeksag @merwok @ZackerySpytz @the-knights-who-say-ni @bedevere-bot