Metabug: Improving C-level coverage #94808

mdboom · 2022-07-13T19:13:00Z

This bug is going to be used to track work in a other bugs to improve the C-level coverage of the CPython test suite.

There is a set of baseline coverage results on main that can be used to find coverage gaps.

The plan, discussed on discuss.python.org is as follows:

Read through the coverage report and record any notable gaps in the checklist below. The goal is not 100% coverage, and each area of improvement will probably require some judgement calls. For example, covering all cases where memory exhaustion can occur is probably not worth the effort. On the other hand, detailed coverage in the eval loop may be worth the effort.
When someone has "read through" a particular source file and added created subitems for any interesting gaps, they should check it off on the list below and add links to any issues created.

Related work:

There is related work to publish coverage results from CPython on a regular basis, but this issue is concerned with using those results to actually reduce our gaps in coverage.

List of source files:

PR: gh-94808:Improve coverage of PyObject_Print #98749

PR: gh-94808: Cover LOAD_GLOBAL for custom dict subtypes #96767

PR: [3.11] gh-94808: Cover LOAD_GLOBAL for custom dict subtypes (GH-96767) #99091

PR: gh-94808: add tests covering PySequence_{Set,Del}Slice #99123

PR: gh-94808: Cover PyEval_GetFuncDesc function #98300

PR: gh-94808: add tests covering PyFunction_GetKwDefaults and PyFunction_SetKwDefaults #98809

PR: [3.11] gh-94808: add tests covering PyEval_GetFuncDesc function (GH-98300) #99126

PR: [3.11] gh-94808: add tests covering PySequence_{Set,Del}Slice (GH-99123) #99133

PR: gh-94808: add tests covering PySequence_[InPlace_]Repeat #99196

PR: gh-94808: add tests covering PySequence_[InPlace]Concat #99319

PR: gh-94808: add tests covering PyFunction_{Get,Set}Closure #99429

PR: gh-94808: improve coverage of number formatting #99472

PR: gh-94808: [coverage] Add an asynchronous generator test #97672

PR: [3.11] gh-94808: improve test coverage of number formatting (GH-99472) #100483

PR: [3.10] gh-94808: improve test coverage of number formatting (GH-99472) #100484

PR: gh-94808: Improve coverage of dictresize #100619

PR: GH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp #102469

PR: gh-94808: Add coverage test for number check #111445

The text was updated successfully, but these errors were encountered:

ezio-melotti · 2022-07-13T20:20:00Z

@mdboom: I think a better approach would be to create sub-checklists or a single issue per file with another checklist for the paths that need coverage, instead of opening dozen of issues for each individual path.

Even having an issue per file will result in 548 new issues though, so I'm not sure if we want to do that preemptively for each file. I'd say it's better to keep the checklist with the files and paths here, and then directly create PRs for each (or multiple) paths.

Another option is to create a project, and handle it there. You can add a new custom field to specify the file, and create draft issues for each path without creating actual issues here (let me know if you need more help with that).

mdboom · 2022-07-13T20:27:26Z

I think a better approach would be to create sub-checklists or a single issue per file with another checklist for the paths that need coverage, instead of opening dozen of issues for each individual path.

I thought about that, but most of the uncovered areas will have independent fixes, and bug-per-area sets up that work to happen.

I'm starting with files that have seen a lot of changes lately, so we're seeing quite a few issues in them. I suspect most files will not be that way -- most will probably have no issues, and we can just check the box here and not create a flood of issues where they aren't needed.

Even having an issue per file will result in 548 new issues though, so I'm not sure if we want to do that automatically for each file. I'd say it's better to keep this checklist here, and create PRs.

Agreed.

Another option is to create a project, and handle it there (let me know if you need help with that).

I'm happy to use a project instead if you'd prefer. IIUC, it's pretty easy to move the existing issues already created into it. I know I can't create a project, but once it's created, I don't know what my limited permissions will allow me to do.

ezio-melotti · 2022-07-13T20:35:48Z

Maybe it would be better to start by trimming down the list to remove files that have no issues, and see how many files are left first.

The remaining files and their paths could be listed here, and if someone starts working on them and wants to discuss the approach they could create the issues lazily or directly create PRs that refers to this meta issues if the fix is straightforward enough.

I don't think having lot of almost empty issues (like #94817) will help this effort.

mdboom · 2022-07-13T21:17:13Z

Maybe it would be better to start by trimming down the list to remove files that have no issues, and see how many files are left first.

I programmatically removed files that have 100% coverage, and then also (manually) removed anything platform specific and all of Modules (which can be handled easily in separate waves later -- they aren't a priority now). This gets us down to 136 tasks from 500+, which is a lot more manageable.

The remaining files and their paths could be listed here, and if someone starts working on them and wants to discuss the approach they could create the issues lazily or directly create PRs that refers to this meta issues if the fix is straightforward enough.

My thinking was this checklist was to say "someone has read through the file and identified all of the potential issues". Some of the issues will have simple tests that can be written, some are dead code, some might reveal bugs, but we need a place to have those discussions and deal with them individually (not here, ideally). For really simple ones, if it's ok to just reference this bug, that's fine by me, but we still need a way to keep track of which files have been vetted to track progress.

I don't think having lot of almost empty issues (like #94817) will help this effort.

Maybe not in general. The ones I've filed so far are directly tied to the faster CPython work, and the ability to move with more confidence there. So there are motivated people who want to close these bugs. But I empathize with the concern of just creating bugs for the sake of creating them.

ezio-melotti · 2022-07-14T00:28:39Z

This gets us down to 136 tasks from 500+, which is a lot more manageable.

This is much better, thanks for doing this!

My thinking was this checklist was to say "someone has read through the file and identified all of the potential issues".

My idea was to do something like:

Python/compile.c
- write_instr is not handling the case where ilen > 2. It might be that those are never seen in practice...? If so, feel free to close this bug.
- check_ann_subscr doesn't have any coverage for slice or tuple kinds.
- optimize_basic_block has some opcodes that aren't covered in the JUMP_IF_FALSE_OR_POP and the JUMP_IF_TRUE_OR_POP cases.
Python/condvar.h
Python/context.c
...

Once people start working on these items, there are different options. They can:

create a single PR to fix all 3, and add it to the checklist (maybe next to the filename)
create multiple PRs to fix them individually, and add them to the checklist (as sub-items)
create a single issue for the file with its own checklist where to discuss all 3, add it to the checklist, and then create PRs linked to the issue
create multiple issues for each of the problems in case they need to be discussed individually (what you were doing)

The first two options work for straightforward cases, the third works if the problems are similar, and the last for more complex cases that require discussions. You can also do this incrementally, i.e. start with a list like the one above, then convert some to PRs and some to issues as needed.

In addition, if you hover with the mouse over a checklist item, a ⨀ icon will appear to the right which will allow you to quickly convert the item to an actual issue if/when you decide to open a discussion about a specific file or problem.

So there are motivated people who want to close these bugs.

That's great to hear, I just wanted to avoid creating a bunch of issues that might end up sitting there indefinitely :)

…gits is provided

mdboom · 2022-07-14T19:31:17Z

Thanks. The revised plan you suggested should work just fine. I didn't know about the feature to automatically open an issue from a checklist item.

brandtbucher · 2022-07-14T21:12:34Z

@pablogsal, should we be backporting these coverage-improving tests to 3.11? I think we should be consistent in our handling of all of them.

I don't think we usually backport test-only PRs, but perhaps these are sort of a special case.

…s provided (GH-94860)

`bool_new` had no coverage. Automerge-Triggered-By: GH:brandtbucher

pablogsal · 2022-07-15T09:23:24Z

Test only PRs are generally ok to backport 👍

…gits is provided (pythonGH-94860) (cherry picked from commit 625ba9b) Co-authored-by: Michael Droettboom <mdboom@gmail.com>

`bool_new` had no coverage. Automerge-Triggered-By: GH:brandtbucher (cherry picked from commit df4d53a) Co-authored-by: Michael Droettboom <mdboom@gmail.com>

…igits is provided (GH-94860) (GH-94882) (cherry picked from commit 625ba9b) Co-authored-by: Michael Droettboom <mdboom@gmail.com> Automerge-Triggered-By: GH:brandtbucher

…erator is already running (#97672)

sobolevn · 2022-11-24T10:06:42Z

WIP:

Rebasing existing PRs to fix merge conflicts with new file structure
Working on PySlice_GetIndices / PySlice_GetIndicesEx

…99472) (cherry picked from commit 7ca45e5) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

(cherry picked from commit 7ca45e5) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

* Correct CVE-2020-10735 documentation (python#100306) * pythongh-94912: Added marker for non-standard coroutine function detection (python#99247) This introduces a new decorator `@inspect.markcoroutinefunction`, which, applied to a sync function, makes it appear async to `inspect.iscoroutinefunction()`. * Docs: Don't upload CI artifacts (python#100330) * pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803) Use a stack to implement os.walk iteratively instead of recursively to avoid hitting recursion limits on deeply nested trees. * pythongh-69929: re docs: Add more specific definition of \w (python#92015) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> * pythongh-89051: Add ssl.OP_LEGACY_SERVER_CONNECT (python#93927) Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Christian Heimes <christian@python.org> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Fixes python#89051 * pythongh-88211: Change lower-case and upper-case to match recommendations in imaplib docs (python#99625) * pythongh-100348: Fix ref cycle in `asyncio._SelectorSocketTransport` with `_read_ready_cb` (python#100349) * pythongh-99925: Fix inconsistency in `json.dumps()` error messages (pythonGH-99926) * Clarify that every thread has its own default context in contextvars (python#99246) * pythongh-99576: Fix cookiejar file that was not truncated for some classes (pythonGH-99616) Co-authored-by: Łukasz Langa <lukasz@langa.pl> * pythongh-100188: Reduce misses in BINARY_SUBSCR_(LIST/TUPLE)_INT (python#100189) Don't specialize if the index is negative. * pythongh-99991: improve docs on str.encode and bytes.decode (python#100198) Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> * pythongh-91081: Add note on WeakKeyDictionary behavior when deleting a replaced entry (python#91499) Co-authored-by: Pieter Eendebak <P.T.eendebak@tudelft.nl> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> * pythongh-85267: Improvements to inspect.signature __text_signature__ handling (python#98796) This makes a couple related changes to inspect.signature's behaviour when parsing a signature from `__text_signature__`. First, `inspect.signature` is documented as only raising ValueError or TypeError. However, in some cases, we could raise RuntimeError. This PR changes that, thereby fixing python#83685. (Note that the new ValueErrors in RewriteSymbolics are caught and then reraised with a message) Second, `inspect.signature` could randomly drop parameters that it didn't understand (corresponding to `return None` in the `p` function). This is the core issue in python#85267. I think this is very surprising behaviour and it seems better to fail outright. Third, adding this new failure broke a couple tests. To fix them (and to e.g. allow `inspect.signature(select.epoll.register)` as in python#85267), I add constant folding of a couple binary operations to RewriteSymbolics. (There's some discussion of making signature expression evaluation arbitrary powerful in python#68155. I think that's out of scope. The additional constant folding here is pretty straightforward, useful, and not much of a slippery slope) Fourth, while python#85267 is incorrect about the cause of the issue, it turns out if you had consecutive newlines in __text_signature__, you'd get `tokenize.TokenError`. Finally, the `if name is invalid:` code path was dead, since `parse_name` never returned `invalid`. * pythonGH-100363: Speed up `asyncio.get_running_loop` (python#100364) * pythonGH-100133: fix `asyncio` subprocess losing `stderr` and `stdout` output (python#100154) * pythongh-100374: Fixed a bug in socket.getfqdn() (pythongh-100375) * pythongh-100129: Add tests for pickling all builtin types and functions (pythonGH-100142) * Remove unused variable from `dis._find_imports` (python#100396) * pythongh-78878: Fix crash when creating an instance of `_ctypes.CField` (python#14837) * pythonGH-69564: Clarify use of octal format of mode argument in help(os.chmod) (python#20621) Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> * pythonGH-99554: Pack location tables more effectively (pythonGH-99556) * Correct typo in typing.py (python#100423) In the docstring of `ParamSpec`, the name of `P = ParamSpec('P')` was mistakenly written as `'T'`. * pythongh-99761: Add `_PyLong_IsPositiveSingleDigit` function to check for single digit integers (python#100064) * pythonGH-99770: Make the correct call specialization fail kind show up in the stats (pythonGH-99771) * pythongh-78997: fix bad rebase of moved test file (python#100424) * pythongh-100344: Add C implementation for `asyncio.current_task` (python#100345) Co-authored-by: pranavtbhat * pythonGH-99554: Trim trailing whitespace (pythonGH-100435) Automerge-Triggered-By: GH:brandtbucher * pythongh-85432: Harmonise parameter names between C and pure-Python implementations of `datetime.time.strftime`, `datetime.datetime.fromtimestamp` (python#99993) * pythongh-57762: fix misleading tkinter.Tk docstring (python#98837) Mentioned as a desired change by terryjreedy on the corresponding issue, since Tk is not a subclass of Toplevel. * pythongh-48496: Added example and link to faq for UnboundLocalError in reference (python#93068) * Fix typo in 3.12 What's New (python#100449) * pythongh-76963: PEP3118 itemsize of an empty ctypes array should not be 0 (pythonGH-5576) The itemsize returned in a memoryview of a ctypes array is now computed from the item type, instead of dividing the total size by the length and assuming that the length is not zero. * pythonGH-100459: fix copy-paste errors in specialization stats (pythonGH-100460) * pythongh-99110: Initialize `frame->previous` in init_frame to fix segmentation fault when accessing `frame.f_back` (python#100182) * pythongh-98712: Clarify "readonly bytes-like object" semantics in C arg-parsing docs (python#98710) * pythongh-92216: improve performance of `hasattr` for type objects (pythonGH-99979) * pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289) * Revert "pythongh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries (pythonGH-100289)" (python#100468) This reverts commit c3c7848. * pythongh-94155: Reduce hash collisions for code objects (python#100183) * Uses a better hashing algorithm to get better dispersion and remove commutativity. * Incorporates `co_firstlineno`, `Py_SIZE(co)`, and bytecode instructions. * This is now the entire set of criteria used in `code_richcompare`, except for `_PyCode_ConstantKey` (which would incorporate the types of `co_consts` rather than just their values). * pythongh-83076: 3.8x speed improvement in (Async)Mock instantiation (python#100252) * pythongh-99482: remove `jython` compatibility parts from stdlib and tests (python#99484) * bpo-40447: accept all path-like objects in compileall.compile_file (python#19883) Signed-off-by: Filipe Laíns <lains@archlinux.org> Signed-off-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * pythonGH-100425: Improve accuracy of builtin sum() for float inputs (pythonGH-100426) * pythongh-68320, pythongh-88302 - Allow for private `pathlib.Path` subclassing (pythonGH-31691) Users may wish to define subclasses of `pathlib.Path` to add or modify existing methods. Before this change, attempting to instantiate a subclass raised an exception like: AttributeError: type object 'PPath' has no attribute '_flavour' Previously the `_flavour` attribute was assigned as follows: PurePath._flavour = xxx not set!! xxx PurePosixPath._flavour = _PosixFlavour() PureWindowsPath._flavour = _WindowsFlavour() This change replaces it with a `_pathmod` attribute, set as follows: PurePath._pathmod = os.path PurePosixPath._pathmod = posixpath PureWindowsPath._pathmod = ntpath Functionality from `_PosixFlavour` and `_WindowsFlavour` is moved into `PurePath` as underscored-prefixed classmethods. Flavours are removed. Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Eryk Sun <eryksun@gmail.com> * pythongh-99947: Ensure unreported errors are chained for SystemError during import (pythonGH-99946) * Add "strict" to dotproduct(). Add docstring. Factor-out common code. (pythonGH-100480) * pythongh-94808: improve test coverage of number formatting (python#99472) * pythongh-100454: Start running SSL tests with OpenSSL 3.1.0-beta1 (python#100456) * pythongh-100268: Add is_integer method to int (python#100439) This improves the lives of type annotation users of `float` - which type checkers implicitly treat as `int|float` because that is what most code actually wants. Before this change a `.is_integer()` method could not be assumed to exist on things annotated as `: float` due to the method not existing on both types. * pythongh-77771: Add enterabs example in sched (python#92716) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871) Co-authored-by: Guido van Rossum <gvanrossum@gmail.com> * pythonGH-91166: Implement zero copy writes for `SelectorSocketTransport` in asyncio (python#31871) Co-authored-by: Guido van Rossum <gvanrossum@gmail.com> * Misc Itertools recipe tweaks (pythonGH-100493) * pythongh-100357: Convert several functions in `bltinsmodule` to AC (python#100358) * Remove wrong comment about `repr` in `test_unicode` (python#100495) * pythongh-99908: Tutorial: Modernize the 'data-record class' example (python#100499) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> * pythongh-100474: Fix handling of dirs named index.html in http.server (pythonGH-100475) If you had a directory called index.html or index.htm within a directory, it would cause http.server to return a 404 Not Found error instead of the directory listing. This came about due to not checking that the index was a regular file. I have also added a test case for this situation. Automerge-Triggered-By: GH:merwok * pythongh-100287: Fix unittest.mock.seal with AsyncMock (python#100496) * pythongh-99535: Add test for inheritance of annotations and update documentation (python#99990) * pythongh-100428: Make float documentation more accurate (python#100437) Previously, the grammar did not accept `float("10")`. Also implement mdickinson's suggestion of removing the indirection. * [Minor PR] Quotes in documentation changed into code blocks (python#99536) Minor formatting fix in documentation Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * pythongh-100472: Fix docs claim that compileall parameters could be bytes (python#100473) * pythongh-100519: simplification to `eff_request_host` in cookiejar.py (python#99588) `IPV4_RE` includes a `.`, and the `.find(".") == -1` included here is already testing to make sure there's no dot, so this part of the expression is tautological. Instead use more modern `in` syntax to make it clear what the check is doing here. The simplified implementation more clearly matches the wording in RFC 2965. Co-authored-by: hauntsaninja <hauntsaninja@gmail.com> * pythongh-99308: Clarify re docs for byte pattern group names (python#99311) * pythongh-92446: Improve argparse choices docs; revert bad change to lzma docs (python#94627) Based on the definition of the collections.abc classes, it is more accurate to use "sequence" instead of "container" when describing argparse choices. A previous attempt at fixing this in python#92450 was mistaken; this PR reverts that change. Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> * Fix name of removed `inspect.Signature.from_builtin` method in 3.11.0a2 changelog (python#100525) * pythongh-100520: Fix `rst` markup in `configparser` docstrings (python#100524) * pythongh-99509: Add `__class_getitem__` to `multiprocessing.queues.Queue` (python#99511) * pythongh-94603: micro optimize list.pop (pythongh-94604) * Remove `NoneType` redefinition from `clinic.py` (python#100551) * pythongh-100553: Improve accuracy of sqlite3.Row iter test (python#100555) * pythonGH-98831: Modernize a ton of simpler instructions (python#100545) * load_const and load_fast aren't families for now * Don't decref unmoved names * Modernize GET_ANEXT * Modernize GET_AWAITABLE * Modernize ASYNC_GEN_WRAP * Modernize YIELD_VALUE * Modernize POP_EXCEPT (in more than one way) * Modernize PREP_RERAISE_STAR * Modernize LOAD_ASSERTION_ERROR * Modernize LOAD_BUILD_CLASS * Modernize STORE_NAME * Modernize LOAD_NAME * Modernize LOAD_CLASSDEREF * Modernize LOAD_DEREF * Modernize STORE_DEREF * Modernize COPY_FREE_VARS (mark it as done) * Modernize LIST_TO_TUPLE * Modernize LIST_EXTEND * Modernize SET_UPDATE * Modernize SETUP_ANNOTATIONS * Modernize DICT_UPDATE * Modernize DICT_MERGE * Modernize MAP_ADD * Modernize IS_OP * Modernize CONTAINS_OP * Modernize CHECK_EXC_MATCH * Modernize IMPORT_NAME * Modernize IMPORT_STAR * Modernize IMPORT_FROM * Modernize JUMP_FORWARD (mark it as done) * Modernize JUMP_BACKWARD (mark it as done) Signed-off-by: Filipe Laíns <lains@archlinux.org> Signed-off-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Jeremy Paige <ucodery@gmail.com> Co-authored-by: Carlton Gibson <carlton@noumenal.es> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Jon Burdo <jon@jonburdo.com> Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Thomas Grainger <tagrain@gmail.com> Co-authored-by: Brad Wolfe <brad.wolfe@gmail.com> Co-authored-by: Richard Kojedzinszky <rkojedzinszky@users.noreply.github.com> Co-authored-by: František Nesveda <fnesveda@users.noreply.github.com> Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com> Co-authored-by: Bisola Olasehinde <horlasehinde@gmail.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Pieter Eendebak <P.T.eendebak@tudelft.nl> Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Co-authored-by: Dominic Socular <BBH@awsl.rip> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Hai Shi <shihai1992@gmail.com> Co-authored-by: amaajemyfren <32741226+amaajemyfren@users.noreply.github.com> Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com> Co-authored-by: david-why <david_why@outlook.com> Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: penguin_wwy <940375606@qq.com> Co-authored-by: Eli Schwartz <eschwartz93@gmail.com> Co-authored-by: Itamar Ostricher <itamarost@gmail.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com> Co-authored-by: Bill Fisher <william.w.fisher@gmail.com> Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Ken Jin <kenjin@python.org> Co-authored-by: Carl Meyer <carl@oddbird.net> Co-authored-by: Filipe Laíns <lains@riseup.net> Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com> Co-authored-by: Barney Gale <barney.gale@gmail.com> Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Eryk Sun <eryksun@gmail.com> Co-authored-by: Sebastian Berg <sebastianb@nvidia.com> Co-authored-by: Illia Volochii <illia.volochii@gmail.com> Co-authored-by: JosephSBoyle <48555120+JosephSBoyle@users.noreply.github.com> Co-authored-by: James Frost <git@frost.cx> Co-authored-by: MonadChains <monadchains@gmail.com> Co-authored-by: Bart Broere <mail@bartbroere.eu> Co-authored-by: Glyph <code@glyph.im> Co-authored-by: hauntsaninja <hauntsaninja@gmail.com> Co-authored-by: Ilya Kulakov <kulakov.ilya@gmail.com> Co-authored-by: Guy Yagev <yourlefthandman8@gmail.com> Co-authored-by: Jakub Kuczys <me@jacken.men>

tqxia · 2022-12-30T12:13:01Z

Hi, I tried to improve coverage for Objects/dictobject.c with this PR:
#100619
BTW, it seems like _PyDict_GetItemHint (which is mentioned in the list) no longer exists.

sobolevn · 2022-12-30T12:52:19Z

The list is quite outdated :)

Including cases fixed in pythonGH-21845

…h-102469)

mdboom added the type-bug An unexpected behavior, bug, or error label Jul 13, 2022

mdboom added a commit to mdboom/cpython that referenced this issue Jul 14, 2022

pythongh-94808: Add coverage for boolobject.c:bool_new

3b97088

bedevere-bot mentioned this issue Jul 14, 2022

gh-94808: Add coverage for boolobject.c:bool_new #94859

Merged

mdboom added a commit to mdboom/cpython that referenced this issue Jul 14, 2022

pythongh-94808: Cover handling non-finite numbers from round when ndi…

3cd7327

…gits is provided

bedevere-bot mentioned this issue Jul 14, 2022

gh-94808: Cover handling non-finite numbers from round when ndigits is provided #94860

Merged

brandtbucher mentioned this issue Jul 14, 2022

gh-94816: Improve coverage of decode_linetable #94853

Merged

brandtbucher pushed a commit that referenced this issue Jul 14, 2022

GH-94808: Cover handling non-finite numbers from round when ndigits i…

625ba9b

…s provided (GH-94860)

miss-islington pushed a commit that referenced this issue Jul 14, 2022

gh-94808: Add coverage for boolobject.c:bool_new (GH-94859)

df4d53a

`bool_new` had no coverage. Automerge-Triggered-By: GH:brandtbucher

ezio-melotti mentioned this issue Jul 15, 2022

skip-news and type-tests badges python/core-workflow#421

Open

bedevere-bot mentioned this issue Jul 15, 2022

[3.11] GH-94808: Cover handling non-finite numbers from round when ndigits is provided (GH-94860) #94882

Merged

bedevere-bot mentioned this issue Jul 15, 2022

[3.11] gh-94808: Add coverage for boolobject.c:bool_new (GH-94859) #94883

Merged

sobolevn mentioned this issue Nov 14, 2022

Refleak in PyGen_New()? Also, PyGen_New() is not tested #99485

Closed

kumaraditya303 pushed a commit that referenced this issue Nov 24, 2022

gh-94808: [coverage] Add an asynchronous generator test where the gen…

5f4ae86

…erator is already running (#97672)

hauntsaninja pushed a commit that referenced this issue Dec 24, 2022

gh-94808: improve test coverage of number formatting (#99472)

7ca45e5

This was referenced Dec 24, 2022

[3.11] gh-94808: improve test coverage of number formatting (GH-99472) #100483

Merged

[3.10] gh-94808: improve test coverage of number formatting (GH-99472) #100484

Merged

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 24, 2022

pythongh-94808: improve test coverage of number formatting (pythonGH-…

ac13643

…99472) (cherry picked from commit 7ca45e5) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 24, 2022

pythongh-94808: improve test coverage of number formatting (pythonGH-…

425c67d

…99472) (cherry picked from commit 7ca45e5) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington added a commit that referenced this issue Dec 24, 2022

gh-94808: improve test coverage of number formatting (GH-99472)

c4aff6d

(cherry picked from commit 7ca45e5) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

miss-islington added a commit that referenced this issue Dec 24, 2022

gh-94808: improve test coverage of number formatting (GH-99472)

b168b0e

(cherry picked from commit 7ca45e5) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

tqxia added a commit to tqxia/cpython that referenced this issue Dec 30, 2022

pythongh-94808: Improve coverage of dictresize

3d236b0

tqxia mentioned this issue Dec 30, 2022

gh-94808: Improve coverage of dictresize #100619

Merged

methane pushed a commit that referenced this issue Dec 31, 2022

gh-94808: Improve coverage of dictresize (GH-100619)

636e9dd

artemmukhin added a commit to artemmukhin/cpython that referenced this issue Mar 5, 2023

[WIP] pythongh-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp

62eb776

artemmukhin added a commit to artemmukhin/cpython that referenced this issue Mar 6, 2023

pythonGH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp

2c387f8

Including cases fixed in pythonGH-21845

artemmukhin added a commit to artemmukhin/cpython that referenced this issue Mar 6, 2023

pythonGH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp

cb45df2

Including cases fixed in pythonGH-21845

artemmukhin added a commit to artemmukhin/cpython that referenced this issue Mar 6, 2023

pythonGH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp

9fe9cae

Including cases fixed in pythonGH-21845

artemmukhin added a commit to artemmukhin/cpython that referenced this issue Mar 6, 2023

pythonGH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp

f6486ee

Including cases fixed in pythonGH-21845

artemmukhin added a commit to artemmukhin/cpython that referenced this issue Mar 6, 2023

pythonGH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp

21c6519

bedevere-bot mentioned this issue Mar 6, 2023

GH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp #102469

Merged

corona10 pushed a commit that referenced this issue Mar 22, 2023

GH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp (gh-102469)

0a60dea

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023

pythonGH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp (pythong…

e139442

…h-102469)

warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023

pythonGH-94808: Cover PyOS_mystrnicmp and PyOS_mystricmp (pythong…

f8c6f92

…h-102469)

corona10 pushed a commit that referenced this issue Oct 29, 2023

gh-94808: Add coverage test for number check (gh-111445)

842e5fc

iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Oct 29, 2023

pythongh-94808: Add coverage test for number check (pythongh-111445)

f2fc8ee

FullteaR pushed a commit to FullteaR/cpython that referenced this issue Nov 3, 2023

pythongh-94808: Add coverage test for number check (pythongh-111445)

55e150c

iritkatriel added the tests Tests in the Lib/test dir label Nov 24, 2023

Metabug: Improving C-level coverage #94808

Metabug: Improving C-level coverage #94808

mdboom commented Jul 13, 2022 •

edited by bedevere-app bot

ezio-melotti commented Jul 13, 2022 •

edited

mdboom commented Jul 13, 2022

ezio-melotti commented Jul 13, 2022

mdboom commented Jul 13, 2022

ezio-melotti commented Jul 14, 2022

mdboom commented Jul 14, 2022

brandtbucher commented Jul 14, 2022

pablogsal commented Jul 15, 2022 •

edited

sobolevn commented Nov 24, 2022

tqxia commented Dec 30, 2022

sobolevn commented Dec 30, 2022

Metabug: Improving C-level coverage #94808

Metabug: Improving C-level coverage #94808

Comments

mdboom commented Jul 13, 2022 • edited by bedevere-app bot

ezio-melotti commented Jul 13, 2022 • edited

mdboom commented Jul 13, 2022

ezio-melotti commented Jul 13, 2022

mdboom commented Jul 13, 2022

ezio-melotti commented Jul 14, 2022

mdboom commented Jul 14, 2022

brandtbucher commented Jul 14, 2022

pablogsal commented Jul 15, 2022 • edited

sobolevn commented Nov 24, 2022

tqxia commented Dec 30, 2022

sobolevn commented Dec 30, 2022

mdboom commented Jul 13, 2022 •

edited by bedevere-app bot

ezio-melotti commented Jul 13, 2022 •

edited

pablogsal commented Jul 15, 2022 •

edited