GH-98831: Modernize a ton of simpler instructions #100545
Merged
+242
−349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this is fiddling with stack frames, there is some weirdness in the `_PyFrame_SetStackPointer()` call.
gvanrossum
changed the title
gvanrossum
added
the
|
If you want to schedule another build, you need to add the |
bedevere-bot
removed
the
brandtbucher
approved these changes
Dec 27, 2022
| family(load_const) = { LOAD_CONST, LOAD_CONST__LOAD_FAST }; | ||
| family(load_fast) = { LOAD_FAST, LOAD_FAST__LOAD_CONST, LOAD_FAST__LOAD_FAST }; |
There was a problem hiding this comment.
Why are these families being removed?
There was a problem hiding this comment.
This part of the file isn't parsed anyway, and if we moved these families into a part where they would be parsed the generator would complain, because it currently doesn't support super-instructions as part of a family.
See also faster-cpython/ideas#495
brandtbucher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These should now exclusively use DECREF_INPUTS() and ERROR_IF().