New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Don't upload CI artifacts #100330
Docs: Don't upload CI artifacts #100330
Conversation
One difference: The CI builds/uploads docs if there are changes in cpython/.github/workflows/doc.yml Lines 23 to 26 in 1cf3d78
Netlify only builds previews if there are changes in Lines 2 to 7 in 1cf3d78
So this PR didn't get a preview (that's fine), but nor would changes to Do we want to add (This was an open question in @sobolevn's #100074 that went unanswered.) |
IMO, no, since it means every PR would get a Netlify build, basically, as most PRs except for docs ones get a NEWS entry, and it seems unlikely to be practically useful/checked, especially since they are short. |
* main: pythongh-89727: Fix os.walk RecursionError on deep trees (python#99803) Docs: Don't upload CI artifacts (python#100330) pythongh-94912: Added marker for non-standard coroutine function detection (python#99247) Correct CVE-2020-10735 documentation (python#100306) pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273) pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551) Docs: Use `PY_VERSION_HEX` for version comparison (python#100179) pythongh-97909: Fix markup for `PyMethodDef` members (python#100089) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205) pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469)
On the CI, we no longer need to upload the built docs as an artifact, as we now have previews on Netlify (added in #92852). For example:
This will save about 49s on the CI and 59.1 MB in storage.
We can also skip uploading the ~1 MB
NEWS
file because it's visible in Netlify previews, for example at: