This repository has been archived by the owner. It is now read-only.
Fixes #138 Fixes #162 Optionally apply config #179
Conversation
options._flags is not always set when using browserify transformations - version affected: "vueify": "^9.4.0" Example of failure in gulp file ```javascript // package.json gulp.task('all', function() { process.env.NODE_ENV = 'production'; return browserify('./source/js/all.js') .transform(babelify.configure({ presets: ["es2015"]})) .transform(vueify) .bundle() .pipe(source('./js/all.js')) .pipe(buffer()) .pipe(rev()) .pipe(gulp.dest(pub)) .pipe(rev.manifest('./build/rev-manifest.json', { base: '', merge: true })) .pipe(gulp.dest('.')); }); ``` ```bash $ gulp all [19:15:56] Using gulpfile ~/gulpfile.js [19:15:56] Starting 'all'... code/node_modules/vueify/index.js:12 sourceMap: options._flags.debug ^ TypeError: Cannot read property 'debug' of undefined at vueify (code/node_modules/vueify/index.js:12:30) ```
I don't actually know if this is the "correct" fix for this issue since I am still working on getting my first Vue app running, but it is a fix :) |
Looks like a duplicate of #172, but I approve this fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
options._flags is not always set when using browserify transformations
Example of failure in gulp file