Skip to content
This repository has been archived by the owner. It is now read-only.

Fixes #138 Fixes #162 Optionally apply config #179

Open
wants to merge 1 commit into
base: master
from

Conversation

@thomas07vt
Copy link

@thomas07vt thomas07vt commented Feb 23, 2017

options._flags is not always set when using browserify transformations

  • version affected: "vueify": "^9.4.0"

Example of failure in gulp file

// gulpfile.js
gulp.task('all', function() {
    process.env.NODE_ENV = 'production';
    return browserify('./source/js/all.js')
        .transform(babelify.configure({ presets: ["es2015"]}))
        .transform(vueify)
        .bundle()
        .pipe(source('./js/all.js'))
        .pipe(buffer())
        .pipe(rev())
        .pipe(gulp.dest(pub))
        .pipe(rev.manifest('./build/rev-manifest.json', {
          base: '',
          merge: true
        }))
        .pipe(gulp.dest('.'));
});
$ gulp all

[19:15:56] Using gulpfile ~/gulpfile.js
[19:15:56] Starting 'all'...
code/node_modules/vueify/index.js:12
    sourceMap: options._flags.debug
                             ^

TypeError: Cannot read property 'debug' of undefined
    at vueify (code/node_modules/vueify/index.js:12:30)
options._flags is not always set when using browserify transformations

- version affected: "vueify": "^9.4.0"

Example of failure in gulp file

```javascript
// package.json
gulp.task('all', function() {
    process.env.NODE_ENV = 'production';
    return browserify('./source/js/all.js')
        .transform(babelify.configure({ presets: ["es2015"]}))
        .transform(vueify)
        .bundle()
        .pipe(source('./js/all.js'))
        .pipe(buffer())
        .pipe(rev())
        .pipe(gulp.dest(pub))
        .pipe(rev.manifest('./build/rev-manifest.json', {
          base: '',
          merge: true
        }))
        .pipe(gulp.dest('.'));
});

```

```bash
$ gulp all

[19:15:56] Using gulpfile ~/gulpfile.js
[19:15:56] Starting 'all'...
code/node_modules/vueify/index.js:12
    sourceMap: options._flags.debug
                             ^

TypeError: Cannot read property 'debug' of undefined
    at vueify (code/node_modules/vueify/index.js:12:30)

```
@thomas07vt
Copy link
Author

@thomas07vt thomas07vt commented Feb 23, 2017

I don't actually know if this is the "correct" fix for this issue since I am still working on getting my first Vue app running, but it is a fix :)

@paul-maxime
Copy link

@paul-maxime paul-maxime commented Mar 29, 2017

Looks like a duplicate of #172, but I approve this fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.