Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element.extend hides exceptions from underlying generators. #123213

Closed
bharel opened this issue Aug 22, 2024 · 2 comments
Closed

Element.extend hides exceptions from underlying generators. #123213

bharel opened this issue Aug 22, 2024 · 2 comments
Labels
topic-XML type-bug An unexpected behavior, bug, or error

Comments

@bharel
Copy link
Contributor

bharel commented Aug 22, 2024 •
edited by bedevere-app bot

Bug report

Bug description:

>>> from xml.etree.ElementTree import Element
>>> Element("a").extend(Element("a") for i in range(10)) # works
>>> Element("a").extend(1/0 for i in range(10)) # throws unrelated TypeError
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: expected sequence, not "generator"

C-implementation only bug.

Submitting a patch...

CPython versions tested on:

3.12, 3.13, CPython main branch

Operating systems tested on:

macOS, Windows

Linked PRs
@bharel bharel added the type-bug An unexpected behavior, bug, or error label Aug 22, 2024
@bharel
Copy link
Contributor Author

bharel commented Aug 22, 2024 •
edited

Also happens on assignment:

>>> Element("a")[:1] = (1/0 for i in range(1))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: expected sequence, not "generator"

Patching up...

@bedevere-app bedevere-app bot mentioned this issue Aug 22, 2024
Merged
@bharel bharel changed the title ElementTree.extend hides exceptions from underlying generators. Element.extend hides exceptions from underlying generators. Aug 22, 2024
serhiy-storchaka pushed a commit that referenced this issue Aug 23, 2024
@bharel
gh-123213: Fixed xml.etree.ElementTree.Element.extend and assignment …
90b6d0e 
…to no longer hide exceptions (GH-123214)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 23, 2024
@bharel @miss-islington
pythongh-123213: Fixed xml.etree.ElementTree.Element.extend and assig…
84735b7 
…nment to no longer hide exceptions (pythonGH-123214)

(cherry picked from commit 90b6d0e)

Co-authored-by: Bar Harel <bharel@barharel.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 23, 2024
@bharel @miss-islington
pythongh-123213: Fixed xml.etree.ElementTree.Element.extend and assig…
6ede9d4 
…nment to no longer hide exceptions (pythonGH-123214)

(cherry picked from commit 90b6d0e)

Co-authored-by: Bar Harel <bharel@barharel.com>
This was referenced Aug 23, 2024
Open
Open
@bharel
Copy link
Contributor Author

bharel commented Aug 23, 2024

Fixed 🎉

@bharel bharel closed this as completed Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-XML type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bharel @picnixz