Skip to content

MNT ignore .env file #29851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged

MNT ignore .env file #29851

merged 1 commit into from
Sep 16, 2024

Conversation

adrinjalali
Copy link
Member

This file is recognised by vscode IDEs and needed to put SCIPY_ARRAY_API=1 in it.

cc @StefanieSenger @ogrisel

Copy link

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: db7f0ba. Link to the linter CI: here

Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ogrisel ogrisel merged commit 4413b6b into scikit-learn:main Sep 16, 2024
37 checks passed
@adrinjalali adrinjalali deleted the env-file branch September 16, 2024 07:35
@StefanieSenger
Copy link
Contributor

StefanieSenger commented Sep 16, 2024

Wow, that was too fast for me!
I was about to ask you to add some documentation on how to use the .env file in the developer guide.

Reference: issues with setting SCIPY_ARRAY_API=1 permanently for IDEs led to this (#29814).

@adrinjalali
Copy link
Member Author

For reference, I found the info here: https://stackoverflow.com/a/60911493/2536294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants