Make the itables field of objects non-nullable.
#5040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, classes that do not implement any interface had a `null` value for their `itables` field. Now, they all use a shared instance of `(ref $itables)` that contains `null`s everywhere. This removes a code path for interface type tests. More importantly, it removes one source of null checks along the code paths for interface method calls.
tanishiking
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, classes that do not implement any interface had a
nullvalue for theiritablesfield. Now, they all use a shared instance of(ref $itables)that containsnulls everywhere.This removes a code path for interface type tests. More importantly, it removes one source of null checks along the code paths for interface method calls.
@tanishiking Does this improve interface calls a bit more, in your benchmarking setup?