fix(compiler): transform pseudo selectors correctly for the encapsulated view #57796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: compiler
GeorgySerga
force-pushed
the
pseudo-selector-functions
branch
from
c341504 to
d7d92a7
Compare
crisbeto
approved these changes
Sep 18, 2024
crisbeto
added
the
action: global presubmit
|
Running a TGP since encapsulation changes tend to be break-ey. |
angular-robot
bot
added
area: compiler
|
Thank you @crisbeto ! I patched my change with more tests and support for more complex selectors. The internal presubmit test, which failed previously, passed with new changes. |
crisbeto
approved these changes
Sep 23, 2024
|
I re-ran the TGP with the latest code, but there are still some breakages. |
angular-robot
bot
added
area: compiler
angular-robot
bot
added
area: compiler
angular-robot
bot
added
area: compiler
angular-robot
bot
added
area: compiler
GeorgySerga
force-pushed
the
pseudo-selector-functions
branch
from
920eb91 to
d146513
Compare
This was referenced Nov 5, 2024
Closed
This was referenced Nov 5, 2024
This was referenced Nov 6, 2024
This was referenced Nov 6, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
JsantosDK
pushed a commit
to JsantosDK/angular
that referenced
this pull request
Nov 11, 2024
…ted view (angular#57796) fix scoping and transforming logic of the `shimCssText` for the components with encapsulated view: - add support for pseudo selector functions - apply content scoping for inner selectors of `:is()` and `:where()` - allow multiple comma separated selectors inside pseudo selectors Fixes angular#45686 PR Close angular#57796
JsantosDK
pushed a commit
to JsantosDK/angular
that referenced
this pull request
Nov 11, 2024
allow css combinators within pseudo selector functions, parsing those correctly. Similarly to previous version, don't break selectors into part if combinators are within parenthesis, for example `:where(.one > .two)` PR Close angular#57796
JsantosDK
pushed a commit
to JsantosDK/angular
that referenced
this pull request
Nov 11, 2024
fix spelling in the comment PR Close angular#57796
JsantosDK
pushed a commit
to JsantosDK/angular
that referenced
this pull request
Nov 11, 2024
…ar#57796) add support for nested and deeply nested (up to three levels) selectors, parse multiple :host selectors, scope selectors within pseudo functions PR Close angular#57796
JsantosDK
pushed a commit
to JsantosDK/angular
that referenced
this pull request
Nov 11, 2024
…r#57796) keep attributes used to scope :host selectors PR Close angular#57796
JsantosDK
pushed a commit
to JsantosDK/angular
that referenced
this pull request
Nov 11, 2024
…angular#57796) fix regexp which is used to test for host inside pseudo selectors PR Close angular#57796
JsantosDK
pushed a commit
to JsantosDK/angular
that referenced
this pull request
Nov 11, 2024
…crease specificity (angular#57796) parse constructions like `:where(:host-context(.foo))` correctly revert logic which lead to decreased specificity if `:where` was applied to another selector, for example `div` is transformed to `div[contenta]` with specificity of (0,1,1) so `div:where(.foo)` should not decrease it leading to `div[contenta]:where(.foo)` with the same specificity (0,1,1) instead of `div:where(.foo[contenta])` with specificity equal to (0,0,1) PR Close angular#57796
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix scoping and transforming logic of the
shimCssTextfor the components with encapsulated view::is()and:where()Fixes #45686
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Pseudo selector functions aren't parsed/transformed correctly at the moment
The provided examples inside the issue are added as unit tests as well as other test cases.
Issue Number: #45686
What is the new behavior?
Specified in unit tests.
:where(.one, .two)stays as a single selector for scoping, previously it was split into two parts:where(.oneand.two).:where(.one > .two)isn't split:is()and:where()are being scoped internally, that is especially important for:where()since this selectors doesn't increase specificity, allowing overloading theme specific values not risking order related issues.Does this PR introduce a breaking change?
Other information