gh-94808: improve coverage of numbers formatting #99472
Open
+39
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
225 tasks
eendebakpt
reviewed
Nov 28, 2022
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
eendebakpt
approved these changes
Nov 29, 2022
hauntsaninja
approved these changes
Dec 23, 2022
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
|
@hauntsaninja congrats on becoming CPython core dev! You totally deserve it, I was not able to vote, but you have all the support from my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
There are two major changes:
PyNumber_Checkinmainformatlongis now covered withcomplexnumbersI can add lots of other cases in other PRs, including:
__int__,__index__, etc (some of which is deprecated)%formattersBut, this PR is minimal to just increase the phisycal coveraged.