gh-99770: Make the correct call specialization fail kind show up #99771
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Sorry, this got overlooked when I was updating the stats for We still don't specify whether the failure is for a builtin function or method descriptor, so this PR would still be a valuable addition, if you are willing to update it. |
|
I updated the failure for the method descriptor. |
| @@ -1251,10 +1251,10 @@ static int | |||
| function_kind(PyCodeObject *code) { | |||
| int flags = code->co_flags; | |||
| if ((flags & (CO_VARKEYWORDS | CO_VARARGS)) || code->co_kwonlyargcount) { | |||
| return SPEC_FAIL_CALL_COMPLEX_PARAMETERS; | |||
| return SPEC_FAIL_CODE_COMPLEX_PARAMETERS; | |||
There was a problem hiding this comment.
function_kind used in subscr、attr and call specialize, move the failure to the common category.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
callspecialization fail kind show up #99770