Skip to content

Add missing Albanian translations for Security and Validator components #58349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

RiniMisini12
Copy link

@RiniMisini12 RiniMisini12 commented Sep 21, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #54548
License MIT

Added missing Albanian translations, in
src/Symfony/Component/Security/Core/Resources/translations/security.sq.xlf and src/Symfony/Component/Validator/Resources/translations/validators.sq.xlf
files respectively.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@wouterj
Copy link
Member

wouterj commented Sep 22, 2024

Thank you for the contribution!

Let's do a friendly ping to @llupa, another Albanian contributor, for a quick double-check of the new translations.

@nicolas-grekas
Copy link
Member

Thank you @RiniMisini12.

@nicolas-grekas nicolas-grekas merged commit 97d0e72 into symfony:5.4 Sep 28, 2024
12 checks passed
@RiniMisini12
Copy link
Author

Thank you as well✌️

@llupa
Copy link
Contributor

llupa commented Sep 28, 2024

@wouterj I flew back home a couple of hours too late!

I am leaving this comment as a note to myself. The translation overall are ok but they have some minor grammar issues. Për Rinin, shumë faleminderit për kontributin!

  • The first translation was in infinitive, reflexive, accusative (për t'u indentifikuar) and was transformed in active voice accusative, but part of the infinitive remains (për të). If kept in active voice this case needs the ablative and the infinitive dropped completely.
  • The second translation does not use compound sentences and It as a pronoun has been dropped completely. Needs to be added.
  • Week validation messages are OK. But I am still mulling over whether using the ablative feels more natural sounding in Albanian.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants