Skip to content

Update clap to v4 #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

coolreader18
Copy link
Member

@coolreader18 coolreader18 commented Sep 23, 2024

Been a long time coming, but it wasn't too hard in the end. Also fixed some parity issues that came up while trying to figure out the correct behavior.

closes #4445 #3512

@youknowone
Copy link
Member

This test is the major blocker:

======================================================================
FAIL: test_scriptdecode (test.test_quopri.QuopriTestCase.test_scriptdecode)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/RustPython/RustPython/pylib/Lib/test/test_quopri.py", line 207, in test_scriptdecode
    self.assertEqual(cout.splitlines(), p.splitlines())
AssertionError: Lists differ: ["Her[17 chars]ecial=3D20", '', '=3DA1=3DA2=3DA3=3DA4=3DA5=3D[515 chars]un!'] != ["Her[17 chars]ecial ", '', '¡¢£¤¥¦§¨©', 'ª«¬\xad®¯°±²³', '´µ[134 chars]un!']

First differing element 0:
"Here's a bunch of special=3D20"
"Here's a bunch of special "

Diff is 909 characters long. Set self.maxDiff to None to see it.

@coolreader18
Copy link
Member Author

Yeah, I opened clap-rs/clap#5747 about it. I think it'll ultimately require patching clap in some way.

@youknowone
Copy link
Member

see also: clap-rs/clap#3903

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants