-
Notifications
You must be signed in to change notification settings - Fork 1.3k
update deps #5119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deps #5119
Conversation
oh, I see the CI results. will try to work on it later |
The CI failures seem unrelated. |
should be fixed. tested on Linux machine |
the |
65c37ff
to
2bf2770
Compare
now not all yanked deps are updated :( |
@ognevnydemon Oh, I am sorry. This patch was independently updating Cargo.lock, right? I will try to lookup previous version. |
yeah, but I just ran |
65c37ff
to
a71608b
Compare
Yes, we update dependencies for various reasons.
Avoiding yanked version is one of the good reason to do it. Any other reasonable suggestion will be also welcome. |
understood. thanks for attention! maybe I'll try to update more deps if they have more fresh version |
uh.. openssl has changes |
a71608b
to
63f2389
Compare
63f2389
to
df6c434
Compare
which crate would affect test_fractions? |
maybe num-complex or other num- one |
b22c07a
to
2a718fa
Compare
I rebased the changes, now this PR updates only lockfile |
The change is partially merged in #5217 |
looks like only one test fails. is this critical? |
yes, I rebased my branch to main so now it's just |
It is hard to say critical, but at the same time, updating deps is not also critical. |
It revealed this patch mergeable without num-complex patch. Thank you for your contributing. |
fixes #5116just for interest, is it good to update other dependencies?
(hope lock file update doesn't break anything. tested only on
x86_64-pc-windows-gnu
toolchain)